-
-
Notifications
You must be signed in to change notification settings - Fork 872
[19.0] [ADD] project_task_product, project_task_product_stock #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
[19.0] [ADD] project_task_product, project_task_product_stock #1626
Conversation
13f169e to
b15f42a
Compare
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Functional + code, just minor a comment
b15f42a to
8e7db51
Compare
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
Interesting... could we split this into two modules? |
@CRogos Just to make sure I get it. You mean moving the "stock" dependency into a separate module. So we have project_task_product that only adds the product to the task, and then something like project_task_stock_product (or something along those lines) that adds the stock dependency and the lot number, right? |
|
@MarinaAForgeFlow yes exactly. |
8e7db51 to
7019b33
Compare
7019b33 to
ba1cca8
Compare
CRogos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but I am not sure if this module fits well in the Odoo system.
When you install sale_project, each task get a sale_line_id, and a sale_line_id has a product_id itself.
- The task.product_id is not prefilled with the sale_line_id.product, when a task is created from a sale order.
- There could be a mismatch between the task.sale_line_id.product_id and the task.product_id.
I see your concern. However, if I am not wrong, this could be solved with a glue module sale_project_task_product, where we ensure that the product on the project task matches the sale line product. Our idea for this module is simply to allow users to define to which product the task relates to, for visibility purposes. |
No description provided.