Skip to content

Conversation

@MarinaAForgeFlow
Copy link

No description provided.

@MarinaAForgeFlow MarinaAForgeFlow marked this pull request as draft December 12, 2025 11:38
@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 19.0-add-project_task_product branch 4 times, most recently from 13f169e to b15f42a Compare December 12, 2025 13:04
@MarinaAForgeFlow MarinaAForgeFlow marked this pull request as ready for review December 12, 2025 13:13
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Functional + code, just minor a comment

@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 19.0-add-project_task_product branch from b15f42a to 8e7db51 Compare December 12, 2025 14:32
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@CRogos
Copy link
Contributor

CRogos commented Dec 12, 2025

Interesting... could we split this into two modules?
stock_product and project_task_product
We are using project, but we are not happy with stock, because we have no shipping/production business.

@MarinaAForgeFlow
Copy link
Author

MarinaAForgeFlow commented Dec 12, 2025

Interesting... could we split this into two modules? stock_product and project_task_product We are using project, but we are not happy with stock, because we have no shipping/production business.

@CRogos Just to make sure I get it. You mean moving the "stock" dependency into a separate module. So we have project_task_product that only adds the product to the task, and then something like project_task_stock_product (or something along those lines) that adds the stock dependency and the lot number, right?

@CRogos
Copy link
Contributor

CRogos commented Dec 12, 2025

@MarinaAForgeFlow yes exactly.

@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 19.0-add-project_task_product branch from 8e7db51 to 7019b33 Compare December 15, 2025 11:01
@MarinaAForgeFlow MarinaAForgeFlow changed the title [19.0] [ADD] project_task_product [19.0] [ADD] project_task_product, project_task_product_stock Dec 15, 2025
@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 19.0-add-project_task_product branch from 7019b33 to ba1cca8 Compare December 15, 2025 11:06
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but I am not sure if this module fits well in the Odoo system.

When you install sale_project, each task get a sale_line_id, and a sale_line_id has a product_id itself.

  • The task.product_id is not prefilled with the sale_line_id.product, when a task is created from a sale order.
  • There could be a mismatch between the task.sale_line_id.product_id and the task.product_id.

@MarinaAForgeFlow
Copy link
Author

MarinaAForgeFlow commented Dec 18, 2025

Code LGTM, but I am not sure if this module fits well in the Odoo system.

When you install sale_project, each task get a sale_line_id, and a sale_line_id has a product_id itself.

  • The task.product_id is not prefilled with the sale_line_id.product, when a task is created from a sale order.
  • There could be a mismatch between the task.sale_line_id.product_id and the task.product_id.

I see your concern. However, if I am not wrong, this could be solved with a glue module sale_project_task_product, where we ensure that the product on the project task matches the sale line product.

Our idea for this module is simply to allow users to define to which product the task relates to, for visibility purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants