Skip to content

[16.0][FIX] project_task_description_template: no duplicate description on template onchange #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntsirintanis wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] project_task_description_template: no duplicate description on template onchange #1606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions project_task_description_template/models/project_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ class ProjectTask(models.Model):

@api.onchange("description_template_id")
def _onchange_description_template_id(self):
if self.description_template_id:
description = self.description if self.description else ""
self.description = description + self.description_template_id.description
for task in self:
if not task.description_template_id:
continue
template_text = task.description_template_id.description or ""
# fields are html, str and compare them
template_text = str(template_text)
current = task.description or ""
current = str(current)
# Avoid duplicating the same template content ANYWHERE in the description
if current == template_text or template_text in current:
continue
task.description = current + template_text