[19.0][MIG] payroll: migrate #227

tishmen · 2025-10-16T16:44:30Z

Scope:

payroll only

Depends on:

None

Summary:

Migrate to Odoo 19.
Follows OCA 19.0 migration tasks (version bump, security field rename, tz API).

Pre-commit:

Ran locally before opening; auto-fixes committed.

Tests:

Local install example: ./odoo/odoo-bin -c odoo.conf -d odoo_payroll_dev -i payroll --log-level=info --stop-after-init
OCA CI will validate on upstream infra.

this commit renames the module from hr_payroll to payroll. This is to avoid conflicting with the hr_payroll module included in Odoo Enterprise

Also removes links to localisations which have not yet been migrated. These can be re-added when the localisations are ported.

author nicolasrsande <[email protected]> 1643135061 -0300 committer nicolasrsande <[email protected]> 1643668459 -0300 fix typo in leave calculation default for worked days should not compute leaves, because leaves are calculated separately we should not add data because it interfers with custom localization payroll modules fix pre-commit add demo data so the test can be executed leaves should be computed in negative value to help creating salary rules Add mantainer key remove mantainer in payroll_account 14.0-minor-fixes fix typo in leave calculation we should not add data because it interfers with custom localization payroll modules fix pre-commit add demo data so the test can be executed leaves should be computed in negative value to help creating salary rules Add mantainer key remove mantainer in payroll_account 14.0-payroll-minor-fixes

accept suggestion use repr() on the string change indentation of error

Currently translated at 93.6% (266 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/ca/

Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/ca/

Currently translated at 86.9% (247 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/

Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/

Currently translated at 78.1% (222 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/it/

…alculation

…nged

…ation

Currently translated at 100.0% (290 of 290 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/

The unittest for the payroll module is broken in several ways: 1. It doesn't actually test anything in the payslip, just the states when various buttons are simulated 2. The payslip is created programatically, so no payslip values are loaded 3. The employee's contract is in "draft" state so even if it tried to load any values it wouldn't work because the contract isn't "open" 4. It modifies a salary input line, but doesn't verify it worked. It doesn't work because of the above mentioned reasons. To ensure a minimal amount of testing: o Make sure the employee's contract is in "open" state o Use the "Form" testing object when creating a payslip to ensure the onchange_employee() is run o Actually test the payroll calculations are done correctly

…salary rule A side effect of the way the payslip line quantity and rate are set when amount_select is set to "code" causes them to never evaluate to zero. When they evaluate to 0 the side effect causes them to be set to 1.0 and 100.0, respectively. "result_qty" in localdict and localdict["result_qty"] or 1.0 "result_rate" in localdict and localdict["result_rate"] or 100.0

tishmen · 2025-10-16T20:47:48Z

Translation best practice in Odoo is to keep placeholders inside the translatable string and interpolate after translation. That pattern looks like self.env._("… %(name)s …") % {"name": value}.
pylint-odoo ports a logging “not‑lazy” rule to translations and flags this interpolation as W8301, but there is no “lazy‑args” form for _(), so the warning is a stylistic false positive for Odoo’s i18n pattern. To remain translator‑friendly and still pass the hook, I added precise, per‑line disables only on the exact interpolation lines (# pylint: disable=translation-not-lazy).
Ruff’s UP031 prefers .format/f‑strings over % formatting. For translatable strings, the percent style with named placeholders is a better fit for Odoo’s extraction and translation workflows. I therefore added per‑line # noqa: UP031 where interpolation occurs after translation to avoid fighting the formatter and to stay consistent with OCA modules.

tishmen · 2025-10-17T00:17:11Z

Odoo 19 drops the separate hr_contract module; “contracts” are now timeline versions inside core HR via the hr.version model.
hr.employee _inherits hr.version (current version in employee.version_id), with multiple versions capturing effective changes via date_version + contract_date_start/contract_date_end.
I replaced hr.contract usages with hr.version: fields like date_start/date_end → date_version/contract_date_start/contract_date_end, and selection via employee._get_contracts(date_start, date_end), considering only overlapping versions.
Views/security were adjusted to target hr.version (contract templates), while hr.contract.type remains in hr for employment type metadata.
To preserve payroll features, I extend hr.version (not hr.contract) to carry payroll-specific fields (e.g., struct_id, schedule_pay) and keep existing flows working on the new model.

tishmen · 2025-10-17T00:20:47Z

@kaynnan @WesleyOliveira98 @marcelsavegnago @CristianoMafraJunior pre-commit and tests are green; please test on RunBoat and review/approve.

payroll/__manifest__.py

CristianoMafraJunior

The commit message should be only: [MIG] payroll: Migration to 19.0
970eaf7

tishmen · 2025-10-19T09:52:13Z

The commit message should be only: [MIG] payroll: Migration to 19.0 970eaf7

I have changed the commit message to the one specified, thank you.

payroll/models/hr_payslip.py

dreispt

Thank you, this looks like solid and brave work.
I made a few minor comments.
The one that could be a bug is the tz handling.

payroll/models/hr_payslip.py

payroll/models/hr_payroll_structure.py

payroll/models/hr_payslip.py

payroll/models/hr_payslip_line.py

payroll/models/hr_salary_rule.py

realsaiko · 2025-11-19T10:34:20Z

Demo data installation fails:
./odoo/odoo-bin -c odoo.conf -d odoo_payroll_dev -i payroll --with-demo --log-level=info --stop-after-init
It still has a reference to the "hr.contract" model that was removed in Odoo v19.0

- Drop hr.contract demo records (Odoo 19) - Use calendar/employee timezone for leave computation - Replace translation % formatting with env._ kwargs - Remove redundant payslip unlink override

tishmen · 2025-12-21T22:33:22Z

Thanks for the detailed review. I’ve pushed updates addressing your points: removed the redundant unlink() override, fixed leave-day timezone handling to use the contract/calendar timezone, and refactored the translation strings to use env._(..., **kwargs) so we can drop the noqa/pylint suppressions. Please take another look when you have a moment.

tishmen · 2025-12-21T22:33:30Z

@realsaiko The demo data still referenced hr.contract, which no longer exists in Odoo 19. I’ve updated the demo XML to remove those hr.contract records and instead set the contract/version fields on the employee records, so payroll --with-demo should install cleanly now. If you can retry the install and confirm, that’d be very helpful.

realsaiko · 2025-12-23T09:52:10Z

@tishmen great, now the demo installation works without errors

hieulucky111 · 2025-12-26T09:38:56Z

I don't see where we can set the Salary Structure on the Employee Version (Contract)

hieulucky111 · 2025-12-26T09:58:38Z

The rest seems ok for me. Functional Test OK

- Add struct_id to the Employee/Payroll contract overview - Copy struct_id from contract templates (whitelist) Functional

tishmen · 2025-12-28T11:46:48Z

@hieulucky111 In Odoo 19 the “contract” is an hr.version edited through the Employee form (the “New Contract” button creates a new version and reloads the employee with context['version_id']), so adding struct_id only on the contract template form
wasn’t enough. I added Salary Structure (struct_id) to the Employee → Payroll → Contract Overview and included it in the template whitelist so “Load a Template” can set it too. Verified on runboat oca-payroll-19-0-pr227-af64a2c7fb96: the field now renders right after “Pay Category”.

hieulucky111

Functional Test Ok

dalonsod · 2026-01-05T15:56:35Z

Hello @tishmen could cherry-pick #248 ?

davejames and others added 30 commits October 16, 2025 18:30

payroll: rename module

f8bbcad

this commit renames the module from hr_payroll to payroll. This is to avoid conflicting with the hr_payroll module included in Odoo Enterprise

payroll: rename install setting for payroll_account module

3369b5e

Also removes links to localisations which have not yet been migrated. These can be re-added when the localisations are ported.

payroll: add original pot file

46b8684

payroll: update new POT file

1b8cf26

[IMP] payroll: black, isort, prettier

9da85df

[MIG] payroll: Migration to 14.0

2e90cd1

[14.0][FIX] payroll: demo rule: python code with no indentation

6cc9f62

[14.0] payroll: new maintainer: appstogrow

8514334

add detail of the exeption in salary rule calculation

2f75018

accept suggestion use repr() on the string change indentation of error

[14.0] [IMP] Code fields for python compute fields

cd2810a

Translated using Weblate (Catalan)

e541387

Currently translated at 93.6% (266 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/ca/

Translated using Weblate (Catalan)

7233f78

Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/ca/

Translated using Weblate (Spanish (Argentina))

b8d51c3

Currently translated at 86.9% (247 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/

Translated using Weblate (Spanish (Argentina))

bf48c3e

Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/

Translated using Weblate (Spanish (Argentina))

d83913c

Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/

Translated using Weblate (Spanish (Argentina))

f815b0b

Currently translated at 100.0% (284 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/

[IMP] update dotfiles [ci skip]

e8682f8

Translated using Weblate (Italian)

cbc7e6f

Currently translated at 78.1% (222 of 284 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/it/

[ADD] payroll: missing tag to compute method

6e0e910

[IMP] payroll: take into account the contract start date in payslip c…

5e70930

…alculation

[IMP] payroll: recalculate worked_days and inputs if structure is cha…

6fdf676

…nged

[IMP] payroll: add amount_qty to paylip inputs

b0397ae

[IMP] payroll: add missing states in status bar

0d84274

[IMP] payroll: ux changes in salary rules views

de6fba3

[IMP] payroll: add support for hr_public_holidays in work time calcul…

9f91f2a

…ation

[IMP] payroll: remove empty lines

383fd45

Translated using Weblate (Spanish (Argentina))

6dfb731

Currently translated at 100.0% (290 of 290 strings) Translation: payroll-14.0/payroll-14.0-payroll Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll/es_AR/

tishmen mentioned this pull request Oct 16, 2025

[19.0][MIG] payroll_account: migrate #228

Open

1 task

tishmen force-pushed the 19.0-mig-payroll branch from d8a42bc to 65fd712 Compare October 16, 2025 19:46

[MIG] payroll: Migration to 19.0

8ac91f8

tishmen force-pushed the 19.0-mig-payroll branch from faa2a49 to 970eaf7 Compare October 17, 2025 00:02

tishmen marked this pull request as ready for review October 17, 2025 00:09

kaynnan reviewed Oct 17, 2025

View reviewed changes

payroll/__manifest__.py Outdated Show resolved Hide resolved

CristianoMafraJunior suggested changes Oct 17, 2025

View reviewed changes

[REF] payroll: remove explicit 'hr' dependency

0695c91

tishmen force-pushed the 19.0-mig-payroll branch 2 times, most recently from d4fd93d to 0695c91 Compare October 19, 2025 09:49

tishmen requested a review from CristianoMafraJunior October 19, 2025 09:52

kaynnan approved these changes Oct 19, 2025

View reviewed changes

dreispt reviewed Nov 18, 2025

View reviewed changes

payroll/models/hr_payslip.py Outdated Show resolved Hide resolved

dreispt reviewed Nov 18, 2025

View reviewed changes

[FIX] payroll: fix demo data and review nits

a8f5145

- Drop hr.contract demo records (Odoo 19) - Use calendar/employee timezone for leave computation - Replace translation % formatting with env._ kwargs - Remove redundant payslip unlink override

Show salary structure on employee contracts

af64a2c

- Add struct_id to the Employee/Payroll contract overview - Copy struct_id from contract templates (whitelist) Functional

hieulucky111 approved these changes Dec 29, 2025

View reviewed changes

lnol mentioned this pull request Dec 29, 2025

[19.0][MIG] datev_import_csv_dtvf: Migration to 19.0 OCA/l10n-germany#209

Open

Uh oh!

[19.0][MIG] payroll: migrate #227

Are you sure you want to change the base?

[19.0][MIG] payroll: migrate #227

Uh oh!

Conversation

tishmen commented Oct 16, 2025

Uh oh!

tishmen commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tishmen commented Oct 17, 2025

Uh oh!

tishmen commented Oct 17, 2025

Uh oh!

Uh oh!

CristianoMafraJunior left a comment

Choose a reason for hiding this comment

Uh oh!

tishmen commented Oct 19, 2025

Uh oh!

Uh oh!

dreispt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

realsaiko commented Nov 19, 2025

Uh oh!

tishmen commented Dec 21, 2025

Uh oh!

tishmen commented Dec 21, 2025

Uh oh!

realsaiko commented Dec 23, 2025

Uh oh!

hieulucky111 commented Dec 26, 2025

Uh oh!

hieulucky111 commented Dec 26, 2025

Uh oh!

tishmen commented Dec 28, 2025

Uh oh!

hieulucky111 left a comment

Choose a reason for hiding this comment

Uh oh!

dalonsod commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

tishmen commented Oct 16, 2025 •

edited

Loading