Skip to content

[19.0][ADD] crm_lead_phone_secondary - #2270

Open
AndreuOForgeFlow wants to merge 1 commit into
OCA:19.0from
ForgeFlow:19.0-add-crm_lead_phone_secondary
Open

[19.0][ADD] crm_lead_phone_secondary#2270
AndreuOForgeFlow wants to merge 1 commit into
OCA:19.0from
ForgeFlow:19.0-add-crm_lead_phone_secondary

Conversation

@AndreuOForgeFlow

@AndreuOForgeFlow AndreuOForgeFlow commented Jan 21, 2026

Copy link
Copy Markdown

@AndreuOForgeFlow
AndreuOForgeFlow force-pushed the 19.0-add-crm_lead_phone_secondary branch 2 times, most recently from 45c9532 to 0588a05 Compare January 21, 2026 10:52
@AndreuOForgeFlow
AndreuOForgeFlow marked this pull request as ready for review January 21, 2026 10:56
BhaveshHeliconia
BhaveshHeliconia suggested changes May 21, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant hasattr and getattr checks

@BhaveshHeliconia

BhaveshHeliconia commented May 21, 2026

Copy link
Copy Markdown
Contributor

phone2 field is not being set in contact when contact is created from lead and it is being cleared when contact is deleted

@AndreuOForgeFlow
AndreuOForgeFlow force-pushed the 19.0-add-crm_lead_phone_secondary branch from 0588a05 to bb200bf Compare June 3, 2026 14:57
@OCA-git-bot OCA-git-bot added series:19.0 mod:crm_lead_phone_secondary Module crm_lead_phone_secondary labels Jun 3, 2026
BhaveshHeliconia
BhaveshHeliconia approved these changes Jun 4, 2026
View reviewed changes

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndreuOForgeFlow
AndreuOForgeFlow force-pushed the 19.0-add-crm_lead_phone_secondary branch from bb200bf to 76677ac Compare June 9, 2026 07:24
@AndreuOForgeFlow
AndreuOForgeFlow force-pushed the 19.0-add-crm_lead_phone_secondary branch from 76677ac to f7bc98f Compare August 3, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod:crm_lead_phone_secondary Module crm_lead_phone_secondary series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndreuOForgeFlow @BhaveshHeliconia @OCA-git-bot