[16.0][REF] l10n_br_fiscal: Melhorias na inutilização de numeração #4141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @rvalyi, |
renatonlima
force-pushed
the
16.0-l10n_br_fiscal-invalidate-number
branch
from
0ccaa53 to
97441ae
Compare
rvalyi
requested changes
Oct 9, 2025
rvalyi
reviewed
Oct 9, 2025
renatonlima
force-pushed
the
16.0-l10n_br_fiscal-invalidate-number
branch
3 times, most recently
from
1f88738 to
181097b
Compare
renatonlima
force-pushed
the
16.0-l10n_br_fiscal-invalidate-number
branch
from
181097b to
0deceee
Compare
renatonlima
force-pushed
the
16.0-l10n_br_fiscal-invalidate-number
branch
3 times, most recently
from
e804b4f to
0689528
Compare
renatonlima
force-pushed
the
16.0-l10n_br_fiscal-invalidate-number
branch
from
0689528 to
9068acb
Compare
rvalyi
reviewed
Oct 15, 2025
| self.ensure_one() | ||
| self._update_document_status(document_id) | ||
| self.state = "done" | ||
| self.write({"state": "done"}) |
Member
There was a problem hiding this comment.
aqui é mais idiomática usar self.state = "done". Isso vai chamar o write automaticamente ainda.
rvalyi
reviewed
Oct 15, 2025
Member
rvalyi
left a comment
rvalyi
left a comment
There was a problem hiding this comment.
2 pequenas considerações mas fora isso me parece OK
| self.ensure_one() | ||
| document_number = self.internal_sequence_id._next() | ||
| if self._is_invalid_number(document_number) or self.check_number_in_use( | ||
| if self.is_invalid_number(document_number) or self.check_number_in_use( |
Member
There was a problem hiding this comment.
eu so acho melhor conservar o _ na frente, assim não fica exposto pro RPC. Dificilmente esse método seria uma falha de segurança mas por padrão é melhor expor apenas o necessário.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Algumas melhorias na invalidação de numeração: