Skip to content

[18.0][IMP] hr_appraisal_oca: search view and translations#1543

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
Esment:18.0-imp-hr_appraisal_oca
Mar 5, 2026
Merged

[18.0][IMP] hr_appraisal_oca: search view and translations#1543
OCA-git-bot merged 1 commit intoOCA:18.0from
Esment:18.0-imp-hr_appraisal_oca

Conversation

@ebauza
Copy link
Contributor

@ebauza ebauza commented Feb 4, 2026

This PR introduces improvements to the hr_appraisal_oca module:

  • Search view improvements
  • Form view refinements
  • Translation updates

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 18.0 milestone Feb 5, 2026
@christian-ramos-tecnativa
Copy link
Contributor

Hello @ebauza do you mind doing a rebase in your branch? It seems that the latest changes in the translations are mixed with the improvement

@ebauza
Copy link
Contributor Author

ebauza commented Feb 6, 2026

Ok!! @christian-ramos-tecnativa, I rebase and split it into 2 commits. Thanks!

@ebauza ebauza force-pushed the 18.0-imp-hr_appraisal_oca branch 2 times, most recently from a39f941 to 44281ee Compare February 6, 2026 12:27
@ebauza
Copy link
Contributor Author

ebauza commented Feb 6, 2026

Done! @christian-ramos-tecnativa
I’ve rebased on top of OCA/hr:18.0 and split the changes into two commits:
– [IMP] functional changes (search view)
– [I18N] translations (.pot/.po)

@ebauza
Copy link
Contributor Author

ebauza commented Feb 16, 2026

Hello!, do you need me to do anything else for you to review it @christian-ramos-tecnativa?. Thanks!!

Copy link
Contributor

@christian-ramos-tecnativa christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the search view improvements — adding filters and group-by options is a nice usability win.

Spotted a small typo in the Spanish translation below. Otherwise LGTM.

@pedrobaeza
Copy link
Member

Please squash commits together.

@ebauza ebauza force-pushed the 18.0-imp-hr_appraisal_oca branch from 4bdf0fd to bf50de8 Compare March 5, 2026 07:45
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1543-by-pedrobaeza-bump-minor, awaiting test results.

@pedrobaeza pedrobaeza changed the title [IMP] hr_appraisal_oca: search view and translations [18.0][IMP] hr_appraisal_oca: search view and translations Mar 5, 2026
@OCA-git-bot OCA-git-bot merged commit 7025bd5 into OCA:18.0 Mar 5, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 92e4626. Thanks a lot for contributing to OCA. ❤️

@ebauza ebauza deleted the 18.0-imp-hr_appraisal_oca branch March 5, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants