[17.0][MIG] hr_holidays_team_manager: Migration to 17.0#1450
[17.0][MIG] hr_holidays_team_manager: Migration to 17.0#1450BhaveshHeliconia wants to merge 7 commits intoOCA:17.0from
Conversation
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
BhaveshHeliconia
force-pushed
the
17.0-mig-hr_holidays_team_manager
branch
from
50eb6f7 to
1bc4322
Compare
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Currently translated at 100.0% (4 of 4 strings) Translation: hr-16.0/hr-16.0-hr_holidays_team_manager Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_holidays_team_manager/it/
BhaveshHeliconia
force-pushed
the
17.0-mig-hr_holidays_team_manager
branch
from
1bc4322 to
3801023
Compare
github-actions
bot
removed
the
stale
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for the migration. The code and tests look good overall -- search() signature updated correctly, Command API applied, and action_validate properly adapted for 17.0. One thing to double-check: in hr_holidays_security.xml, the implied_ids for group_hr_holidays_officer was changed from (4, ref(...)) (link) to Command.set(...) (replace). The 16.0 version used link semantics to add the user group without disturbing other implied groups that might be set by third-party modules. Consider using Command.link() here instead to preserve the same behavior.
|
|
||
| <record id="group_hr_holidays_officer" model="res.groups"> | ||
| <field name="name">Time off/Holiday Officer</field> | ||
| <field |
There was a problem hiding this comment.
In 16.0 this was (4, ref('hr_holidays.group_hr_holidays_user')) which uses link/add semantics. Command.set() replaces all implied groups, which could remove implied groups added by other installed modules. Should this be Command.link(ref('hr_holidays.group_hr_holidays_user')) instead to preserve the original behavior?
There was a problem hiding this comment.
Yes, you're right — it should use Command.link() to preserve the original link semantics.
I've replaced Command.set(ref('hr_holidays.group_hr_holidays_user')) with Command.link(ref('hr_holidays.group_hr_holidays_user')).
Thanks for pointing this out and for the review.
BhaveshHeliconia
force-pushed
the
17.0-mig-hr_holidays_team_manager
branch
from
3801023 to
5115421
Compare
BhaveshHeliconia
force-pushed
the
17.0-mig-hr_holidays_team_manager
branch
from
5115421 to
c4971ed
Compare
5 participants
No description provided.