[18.0][MIG] hr_employee_document: Migration to 18.0 by BhaveshHeliconia · Pull Request #1418 · OCA/hr

BhaveshHeliconia · 2024-12-13T05:18:27Z

No description provided.

ChristianSantamaria

Be careful, you must first perform the pre-commit by making the first commit with the name: "[IMP] hr_employee_document: pre-commit auto fixes" and then add the changes and proceed to commit: "[MIG] hr_employee_document: Migration to 17.0"

More info: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

BhaveshHeliconia · 2025-06-03T09:38:39Z

@ChristianSantamaria, I followed the instructed steps. However, when running the format/patch command for the pre-commit, there were no changes detected. As a result, the commit [IMP] hr_employee_document: pre-commit auto fixes is not included in this PR since there were no auto-fixes needed.

peluko00

LGTM! Code review and tested in runboat

ChristianSantamaria · 2025-06-03T10:21:07Z

@BhaveshHeliconia Okey, could you check the tests since there are lines not covered?

andreampiovesana

LGTM

BhaveshHeliconia · 2025-07-04T10:13:28Z

@ChristianSantamaria : Please review. Thanks

BhaveshHeliconia · 2025-07-23T10:14:51Z

Ping @ChristianSantamaria

OCA-git-bot · 2025-08-04T07:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

andreampiovesana · 2025-08-08T06:55:20Z

merge?

BhaveshHeliconia · 2026-01-06T09:25:48Z

Hey @OCA/human-resources-maintainers Could you merge this?

dreispt · 2026-01-06T19:56:15Z

/ocabot migration hr_employee_document
/ocabot merge nobump

OCA-git-bot · 2026-01-06T19:56:23Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1418-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

peluko00 · 2026-01-07T06:25:16Z

Maybe is not working @dreispt, can you retry the command please?

marcelsavegnago

LGTM

alexey-pelykh

Thanks for the migration, looks good overall. The check_access_rights -> check_access adaptation for 18.0 is correct.

One thing worth noting: read_group() is deprecated since Odoo 17 in favor of _read_group() (see odoo/odoo#110737). In hr_employee.py _compute_document_count, the call to self.env["ir.attachment"].read_group(...) could be updated to use _read_group with the new signature. Not blocking given the module works and CI is green, but it would be good to address in a follow-up or before merge if easy enough.

Also minor: the .pot file still references Project-Id-Version: Odoo Server 17.0 -- should be regenerated for 18.0 (usually handled by oca-gen-addon-readme / oca-gen-pot).

alexey-pelykh · 2026-03-01T15:06:37Z

hr_employee_document/models/hr_employee.py

+        self.document_count = 0
+        attachment_groups = self.env["ir.attachment"].read_group(
+            [("res_model", "=", "hr.employee"), ("res_id", "in", self.ids)],
+            ["res_id"],


read_group() is deprecated since 17.0. Consider migrating to _read_group():

results = self.env['ir.attachment']._read_group( [('res_model', '=', 'hr.employee'), ('res_id', 'in', self.ids)], groupby=['res_id'], aggregates=['__count'], ) count_dict = {res_id.id: count for res_id, count in results}

Thanks for the review and for pointing this out.
I've updated the read_group() call to use _read_group() and regenerated the .pot file for 18.0.

…mployee profile [UPD] Update hr_employee_document.pot [ADD] icon.png

Replacing google drive link in view by nothing, that is deleting, breaks the view inheritance. Making it invisible instead. hr_employee_document 12.0.1.0.1

hr_employee_document 12.0.1.1.0

[UPD] Update hr_employee_document.pot

[UPD] README.rst

[UPD] Update hr_employee_document.pot [UPD] README.rst hr_employee_document 13.0.2.0.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-13.0/hr-13.0-hr_employee_document Translate-URL: https://translation.odoo-community.org/projects/hr-13-0/hr-13-0-hr_employee_document/

…mployee groups can access to attachments related to own employee [UPD] README.rst hr_employee_document 13.0.3.0.0

TT37024 [UPD] Update hr_employee_document.pot [UPD] README.rst

TT40359

…void side effects. The purpose of this module is to allow a basic user (without hr permissions) to view the attachments related to his employee (hr.employee). By default a basic user cannot access to hr.employee model and therefore cannot see the attachments (ir.attachment) linked to it. This change overrides some things to allow the user's employee attachments to be displayed. TT44536

Currently translated at 100.0% (7 of 7 strings) Translation: hr-16.0/hr-16.0-hr_employee_document Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_document/it/

Currently translated at 100.0% (7 of 7 strings) Translation: hr-16.0/hr-16.0-hr_employee_document Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_document/es/

Currently translated at 100.0% (7 of 7 strings) Translation: hr-16.0/hr-16.0-hr_employee_document Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_document/fr/

…ployees for one user TT49830

BhaveshHeliconia mentioned this pull request Dec 19, 2024

Migration to version 18.0 #1393

Open

23 tasks

BhaveshHeliconia force-pushed the 18.0-mig-hr_employee_document branch from b9c639d to df67f21 Compare February 25, 2025 05:18

ChristianSantamaria suggested changes Jun 3, 2025

View reviewed changes

BhaveshHeliconia requested a review from ChristianSantamaria June 3, 2025 09:38

peluko00 approved these changes Jun 3, 2025

View reviewed changes

andreampiovesana approved these changes Jun 20, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-hr_employee_document branch from df67f21 to 25f30f8 Compare July 4, 2025 10:08

ChristianSantamaria approved these changes Aug 4, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Aug 4, 2025

$fracabdel1$

fracabdel1 approved these changes Oct 28, 2025

View reviewed changes

PaulGoubert approved these changes Jan 6, 2026

View reviewed changes

dreispt approved these changes Jan 6, 2026

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Jan 6, 2026

OCA-git-bot added a commit that referenced this pull request Jan 6, 2026

Merge PR #1418 into 18.0

57527b3

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Jan 6, 2026

marcelsavegnago approved these changes Jan 8, 2026

View reviewed changes

alexey-pelykh reviewed Mar 1, 2026

View reviewed changes

alexey-pelykh and others added 2 commits March 5, 2026 11:48

[12.0][ADD] hr_employee_document: various documents attached to the e…

9e2ea4f

…mployee profile [UPD] Update hr_employee_document.pot [ADD] icon.png

Added translation using Weblate (French)

62bef6e

badbole and others added 21 commits March 5, 2026 11:48

Added translation using Weblate (Croatian)

f0e41a3

[12.0][FIX] hr_employee_document: google_drive_link invisible

967a6c9

Replacing google drive link in view by nothing, that is deleting, breaks the view inheritance. Making it invisible instead. hr_employee_document 12.0.1.0.1

[IMP] hr_employee_document: add attachment preview

d32db93

hr_employee_document 12.0.1.1.0

[IMP] hr_employee_document: black, isort, prettier

01c6692

[MIG] hr_employee_document: Migration to 13.0

d7d7a61

[UPD] Update hr_employee_document.pot

[UPD] Brainbean Apps => CorporateHub

7a7b8fa

[UPD] README.rst

[IMP] hr_employee_document: Add security rule to allow user without e…

2231d91

…mployee groups can access to attachments related to own employee [UPD] README.rst hr_employee_document 13.0.3.0.0

[IMP] hr_employee_document: black, isort, prettier

30c9bbb

[MIG] hr_employee_document: Migration to 14.0

7d2bac3

TT37024 [UPD] Update hr_employee_document.pot [UPD] README.rst

[MIG] hr_employee_document: Migration to 15.0

f352965

TT40359

Added translation using Weblate (Italian)

15aadb0

Added translation using Weblate (Spanish)

a90686d

[MIG] hr_employee_document: Migration to 16.0

0b06564

Translated using Weblate (Italian)

2c1d208

Currently translated at 100.0% (7 of 7 strings) Translation: hr-16.0/hr-16.0-hr_employee_document Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_document/it/

Translated using Weblate (Spanish)

e9ef1fb

Currently translated at 100.0% (7 of 7 strings) Translation: hr-16.0/hr-16.0-hr_employee_document Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_document/es/

Translated using Weblate (French)

614a318

Currently translated at 100.0% (7 of 7 strings) Translation: hr-16.0/hr-16.0-hr_employee_document Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_document/fr/

[IMP] hr_employee_document: pre-commit auto fixes

b36eb8a

[MIG] hr_employee_document: Migration to 17.0

8ad7b22

[FIX] hr_employee_document: Correct condition if there are several em…

9acd659

…ployees for one user TT49830

BhaveshHeliconia force-pushed the 18.0-mig-hr_employee_document branch from 25f30f8 to 8171976 Compare March 5, 2026 06:37

[MIG] hr_employee_document: Migration to 18.0

d059da3

BhaveshHeliconia force-pushed the 18.0-mig-hr_employee_document branch from 8171976 to d059da3 Compare March 5, 2026 06:49

Uh oh!

Conversation

BhaveshHeliconia commented Dec 13, 2024

Uh oh!

ChristianSantamaria left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Jun 3, 2025

Uh oh!

peluko00 left a comment

Choose a reason for hiding this comment

Uh oh!

ChristianSantamaria commented Jun 3, 2025

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Jul 4, 2025

Uh oh!

BhaveshHeliconia commented Jul 23, 2025

Uh oh!

OCA-git-bot commented Aug 4, 2025

Uh oh!

andreampiovesana commented Aug 8, 2025

Uh oh!

BhaveshHeliconia commented Jan 6, 2026

Uh oh!

dreispt commented Jan 6, 2026

Uh oh!

OCA-git-bot commented Jan 6, 2026

Uh oh!

peluko00 commented Jan 7, 2026

Uh oh!

marcelsavegnago left a comment

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

alexey-pelykh Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants