[18.0][MIG] hr_holidays_public_overtime: Migration to 18.0 - #190
[18.0][MIG] hr_holidays_public_overtime: Migration to 18.0#190BhaveshHeliconia wants to merge 7 commits into
Conversation
9a33c9a to
10ab746
Compare
10ab746 to
d8c1a24
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
d8c1a24 to
b1c9853
Compare
github-actions
Bot
removed
the
stale
b1c9853 to
dbc6028
Compare
gfcapalbo
left a comment
gfcapalbo
left a comment
There was a problem hiding this comment.
Add a short description to MR and check my comments.
Looks good.
| # | ||
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Odoo Server 15.0\n" |
| def _update_overtime(self, employee_attendance_dates=None): | ||
| """Set the flag in context to exclude public holidays""" | ||
| if employee_attendance_dates is None: | ||
| employee_attendance_dates = self._get_attendances_dates() |
There was a problem hiding this comment.
We know that _get_attendances_dates will always return a defaultdict https://github.com/OCA/OCB/blob/18.0/addons/hr_attendance/models/hr_attendance.py#L307 and this is where our parameter employee_attendance_date comes from.
I have checked the 18 source code and see no reason to cover the case of a normal dict by protecting user getattr. this is okay.
| @@ -0,0 +1,4 @@ | |||
| - Holger Brunn \<mail@hunki-enterprises.com\> | |||
| (<https://hunki-enterprises.com>) | |||
| - [Heliconia Solutions Pvt. Ltd.\](<https://www.heliconia.io>) | |||
| "hr_holidays_public", | ||
| "hr_attendance", | ||
| ], | ||
| "auto_install": True, |
There was a problem hiding this comment.
this is okay because we are bridging hr__holidays_public and the core attendance module.
dbc6028 to
87ece5a
Compare
|
@gfcapalbo I've addressed your suggestions and pushed the changes. Could you please review when you get a chance? |
Currently translated at 100.0% (1 of 1 strings) Translation: hr-holidays-15.0/hr-holidays-15.0-hr_holidays_public_overtime Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-15-0/hr-holidays-15-0-hr_holidays_public_overtime/it/
Currently translated at 100.0% (1 of 1 strings) Translation: hr-holidays-15.0/hr-holidays-15.0-hr_holidays_public_overtime Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-15-0/hr-holidays-15-0-hr_holidays_public_overtime/de/
87ece5a to
76326f5
Compare
OCA-git-bot
added
series:18.0
mod:hr_holidays_public_overtime
|
@gfcapalbo your feedback was addressed. Please have another look. Thanks. |
7 participants
No description provided.