[19.0][MIG] crm_lead_to_opportunity_contact - #755
Open
MarcGForgeFlow wants to merge 6 commits into
Open
Conversation
With this module, in the lead to opportunity wizard, you have a new option: create a new contact on an existing customer
Simple migration of the module crm_lead_to_opportunity_contact from v14 to v16
OCA-git-bot
added
series:19.0
mod:crm_lead_to_opportunity_contact
MarcGForgeFlow
force-pushed
the
19.0-mig-crm_lead_to_opportunity_contact
branch
from
July 8, 2026 15:13
dedbf98 to
fa7b216
Compare
MarcGForgeFlow
force-pushed
the
19.0-mig-crm_lead_to_opportunity_contact
branch
from
July 8, 2026 16:10
fa7b216 to
24b0d7f
Compare
Author
|
@alexis-via I've pushed an [IMP] commit on top of the migration, extending the wizard so an existing contact can also be linked, not only created. Since it's your module, does the improvement look good to you? Happy to adjust it. |
MarcGForgeFlow
force-pushed
the
19.0-mig-crm_lead_to_opportunity_contact
branch
from
July 9, 2026 14:18
47cabe5 to
41c2245
Compare
… existing customer
MarcGForgeFlow
force-pushed
the
19.0-mig-crm_lead_to_opportunity_contact
branch
from
July 10, 2026 16:14
41c2245 to
bd918ff
Compare
…hen it cannot be normalized Odoo keys partners on the normalized email and falls back to the raw input when normalization fails, as documented in MailThread._partner_find_from_emails(). The customer of the wizard is looked up through that tool, so it matches leads carrying a malformed email, while the contact lookup gave up on them. Apply the same rule to the contact lookup, so that both questions of the wizard use one single criterion.
The tests create partners. Run at install time, the registry only knows the fields added by this module's dependencies, while the database holds the columns of every installed module: a required field added by a module loaded later, such as purchase_stock.group_rfq, then gets no default and its NOT NULL constraint rejects the insert. The tests pass on the OCA CI because only crm and its dependencies are installed there, but they cannot run on a complete database.
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of crm_lead_to_opportunity_contact to 19.0.
This revives #533 (16.0 migration), which was closed by the stale bot due to inactivity, not rejected. The original author's commits are preserved.
@alexis-via FYI (original author).