Skip to content

[18.0][MIG] asterisk_click2dial #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
antoniodavid wants to merge 195 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] asterisk_click2dial #350

antoniodavid wants to merge 195 commits into from

Conversation

@antoniodavid
Copy link

@antoniodavid antoniodavid commented Sep 12, 2025

No description provided.

Alexis de Lattre added 30 commits September 10, 2025 14:34
@antoniodavid
Initial import.
0c00ae0 
Long life to the asterisk_click2dial module for OpenERP !
@antoniodavid
- smaller "Dial" button on partner contact
36196d5 
- option to allow the use of phone numbers in National format,
  as discussed with Albert. This option is on the definition of the server.
  -> required a large change of the reformat number process
- added exact link to documentation in module description
- some clean-up
@antoniodavid
Vianney changed the name of the 'alert-info' field to 'alert_info'...
218135b 
but he also made the change in the name of the SIP header !
This commit reverts this mistake.
@antoniodavid
[FIX] WaitTime parameter is now really taken into account
b8f3fe2 
In fact, it corresponds to the 'Timeout' instruction for the Asterisk Manager
@antoniodavid
Make error messages displayed on screen translatable.
880dc53 
Add French translation for these messages.
@antoniodavid
- Add copyright headers in XML files
65691a8 
- Convert the comments for the functions to the standard style
@antoniodavid
Country_prefix is now a "required" field.
887490f 
Added "active" field on asterisk.server object.
In order to access all the Asterisk servers, included the desactivated ones,
I added a view dedicated to the object asterisk.server, which is accessible
under Administration > Configuration.
@antoniodavid
Check that the user has a callerID.
342e76a 
Thanks to Bernat Brunet from NaN for pointing this out.
@antoniodavid
First implementation of get_name_from_phone_number function
7dfb65c 
Make phone and mobile fields searchable
Took into account some pylint coding convention suggestions
@antoniodavid
Much better function get_name_from_phone_number :
ac0cf0a 
- we now handle the fact that phone numbers may contain spaces or special chars such in OpenERP, which is often the case in real life
- check input number
@antoniodavid
Add AGI script and its wrapper to manage timeout.
840ea8b
@antoniodavid
Don't put the admin user by default, it's not a good example.
c0230de 
Added a comment about the user rights.
@antoniodavid
Add a group "Asterisk CallerID" decidated to the CallerID name lookup…
f5cc346 
… feature

Update module description.
@antoniodavid
Better context handling
335768d 
Update in comments
@antoniodavid
Update URL of the module documentation.
78e2509
@antoniodavid
[FIX] There shouldn't be any space between the name and the phone num…
57dbf37 
…ber in the callerID instruction to Asterisk.

Patch courtesy of Marcel van der Boom. Thanks for your feedback !
@antoniodavid
- Send CallerID to Asterisk as UTF-8 by default
1a86ecc 
  Accoring to my tests and the info I got, SIP phones support UTF-8 fine
- Create a command line option to convert the name from UTF-8 to ASCII (-a)
- add default parameter to the help message
@antoniodavid
Networking code is now IPv6-ready
e9763d1
@antoniodavid
[FIX] Avoid a view conflict with the "base_contact" module by adding …
534510d 
…a priority on the res.partner view.

Better handling of check functions when there are several ids.
@antoniodavid
[FIX] Base_contact also inherit the view base.view_partner_address_fo…
59c0950 
…rm1 and removes the "mobile" field, so I need to change the priority to this view too.
@antoniodavid
[FIX] Wrong if condition fixed
5fec8db 
Thanks to Todd Johnson for pointing out this mistake.
@antoniodavid
Avoid code duplication in views : the full tree/form view for Asteris…
c0d9b15 
…k server now inherit from the tree/form view in the company form.
@antoniodavid
Changed author name to Akretion
a385755 
Changed view names
Great solution (thanks to Sebastien for finding it !) to avoid having 2 different tree&form views for asterisk server.
@antoniodavid
Add support for XML-RPC secure with SSL.
edb8814
@antoniodavid
Fallback to utf-8 if sys.stdout.encoding fails.
77940c4
@antoniodavid
Create a dedicated Tab in the res_users view.
3105e9f 
Larger phone field in res_partner_address (smaller 'dial' button)
@antoniodavid
Start to clean the networking code :
c2041fb 
. adds debug message
. starts to better manage character encoding in the networking code... but I still need more info about AMI on this.
@antoniodavid
Large code cleanup :
afc567b 
- now parses answers received from Asterisk and display errors to the user
- now properly encodes the requests sent to Asterisk in ASCII (AMI doesn't support other charsets unfortunately)
- required fields are now required=True
- Single constraint function for all asterisk.server fields
- Fields that shouldn't have non-ascii caracters are not validated if they have non-ASCII caracters (including CallerID)
- clean-up error message code
- if no Asterisk server is defined for a user, it takes the first Asterisk serve
r defined
- methods now always return something
@antoniodavid
Cosmetic changes.
f15c60b
@antoniodavid
Convert to new logger API of OpenERP 6.1
4750e91 
Remove print
OCA-git-bot and others added 25 commits September 10, 2025 14:34
@OCA-git-bot @antoniodavid
[UPD] README.rst
a313ad1
@antoniodavid
Translated using Weblate (Portuguese (Brazil))
200c4bd 
Currently translated at 100.0% (91 of 91 strings)

Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/pt_BR/
@nimarosa @antoniodavid
Added translation using Weblate (Spanish (Argentina))
899043f
@nimarosa @antoniodavid
Translated using Weblate (Spanish (Argentina))
7bebb4d 
Currently translated at 96.7% (88 of 91 strings)

Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/es_AR/
@Urvisha-OSI @antoniodavid
[FIX] fixed pre-commit faild issues
3d3bb78
@alexis-via @antoniodavid
asterisk_click2dial: AMI -> ARI transition
6d01527
@mymage @antoniodavid
Translated using Weblate (Italian)
00ac14f 
Currently translated at 7.6% (7 of 91 strings)

Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/it/
@sysadminmatmoz @antoniodavid
Translated using Weblate (Slovenian)
190175f 
Currently translated at 8.7% (8 of 91 strings)

Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/sl/
@antoniodavid
[UPD] Update asterisk_click2dial.pot
e016d0b
@OCA-git-bot @antoniodavid
asterisk_click2dial 14.0.2.0.0
172cb73
@weblate @antoniodavid
Update translation files
3fde3ea 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/
@OCA-git-bot @antoniodavid
[UPD] README.rst
22a106f
@Ivorra78 @antoniodavid
Translated using Weblate (Spanish)
78c245c 
Currently translated at 100.0% (91 of 91 strings)

Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/es/
@luisDIXMIT @antoniodavid
[IMP] asterisk_click2dial: pre-commit auto fixes
da18a87
@luisDIXMIT @antoniodavid
[MIG] asterisk_click2dial: Migration to 16.0
c161ccf
@antoniodavid
[UPD] Update asterisk_click2dial.pot
83071b3
@luisDIXMIT @antoniodavid
[IMP] asterisk_click2dial: pre-commit auto fixes
82954fd
@luisDIXMIT @antoniodavid
[MIG] asterisk_click2dial: Migration to 17.0
d5b8b81
@antoniodavid
[UPD] Update asterisk_click2dial.pot
c40b312
@OCA-git-bot @antoniodavid
[BOT] post-merge updates
13817f2
@weblate @antoniodavid
Update translation files
d06ac78 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: connector-telephony-17.0/connector-telephony-17.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-17-0/connector-telephony-17-0-asterisk_click2dial/
@mymage @antoniodavid
Translated using Weblate (Italian)
b903e8a 
Currently translated at 98.7% (77 of 78 strings)

Translation: connector-telephony-17.0/connector-telephony-17.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-17-0/connector-telephony-17-0-asterisk_click2dial/it/
@mymage @antoniodavid
Translated using Weblate (Italian)
5a9bb2d 
Currently translated at 100.0% (78 of 78 strings)

Translation: connector-telephony-17.0/connector-telephony-17.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-17-0/connector-telephony-17-0-asterisk_click2dial/it/
@mymage @antoniodavid
Translated using Weblate (Italian)
8efcf58 
Currently translated at 100.0% (78 of 78 strings)

Translation: connector-telephony-17.0/connector-telephony-17.0-asterisk_click2dial
Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-17-0/connector-telephony-17-0-asterisk_click2dial/it/
@antoniodavid
[IMP] asterisk_click2dial: pre-commit execution
006d399
@antoniodavid antoniodavid mentioned this pull request Sep 12, 2025
Open
3 tasks
@antoniodavid antoniodavid force-pushed the 18.0-mig-asterisk_click2dial branch from c8e4cd3 to 807ad18 Compare September 12, 2025 04:41
@Dkodsy
Copy link

Dkodsy commented Sep 26, 2025

@antoniodavid
Hi — thanks for the great work! Just to confirm: is the module already updated for Odoo 18 but not yet included in the 18 branch?

@cvinh
Copy link
Contributor

cvinh commented Nov 1, 2025

thanks for migrating this module
can you please fix pre-commit ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.