[17.0][IMP] voip_oca: Update z-index for proper layering #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the web_responsive module is installed, the VoIP component is not displayed in the main menu because web_responsive has a higher z-index. https://github.com/OCA/web/blob/32184c6f6b6c34a2660e4adbe8271f2021f22bdf/web_responsive/static/src/components/apps_menu/apps_menu.scss#L35 After this commit, the VoIP component will always be displayed.
Contributor
|
Hi @etobella, |
Member
|
At the same time you are there, can you please hide the systray icon when no voip provider is set in the user? |
pedrobaeza
reviewed
Aug 5, 2025
| height: auto; | ||
| max-height: 70%; | ||
| z-index: 99; | ||
| z-index: 1001; |
Member
There was a problem hiding this comment.
I would say this z-index is on purpose for not being on top on certain cases, isn't it @etobella ?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
pedrobaeza
removed
the
stale
Member
|
Could you try to show what happens if we open a readonly O2M line or opening a wizard? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
web_responsivemodule is installed, the VoIP component is not displayed in the main menu becauseweb_responsivehas a higher z-index.Before
voip_oca_before.mp4
After this commit, the VoIP component will always be displayed.
voip_oca_after.mp4
@Tecnativa @pedrobaeza @etobella could you please review this?