[FIX] account_reconcile_oca: keep candidates list page/scroll when selecting a counterpart#1000
Draft
CarlosRoca13 wants to merge 2 commits into
Draft
[FIX] account_reconcile_oca: keep candidates list page/scroll when selecting a counterpart#1000CarlosRoca13 wants to merge 2 commits into
CarlosRoca13 wants to merge 2 commits into
Conversation
CarlosRoca13
force-pushed
the
18.0-FIX-account_reconcile_oca
branch
from
4072617 to
d45d91d
Compare
OCA-git-bot
added
series:18.0
mod:account_reconcile_oca
CarlosRoca13
changed the title
…lecting a counterpart The candidates list is rendered inside the reconcile form. Selecting a counterpart updates the parent record, which re-renders the form and passes a new (but value-wise identical) domain to the list. RelationalModel resets the pagination offset to 0 whenever it is reloaded "from above with a domain", so the user was sent back to the first page of candidates (and the right panel scrolled away) on every click. - Add ReconcileMoveLineModel, which drops the domain from the reload params when its value hasn't changed, preserving the current page. A real search change still carries a different domain and resets the page as expected. - Wire the new model into ReconcileMoveLineView. - Preserve the scroll position of the reconcile panel in ReconcileMoveLineController.openRecord.
CarlosRoca13
force-pushed
the
18.0-FIX-account_reconcile_oca
branch
from
d45d91d to
2a39e41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The candidates list is rendered inside the reconcile form. Selecting a counterpart updates the parent record, which re-renders the form and passes a new (but value-wise identical) domain to the list. RelationalModel resets the pagination offset to 0 whenever it is reloaded "from above with a domain", so the user was sent back to the first page of candidates (and the right panel scrolled away) on every click.
cc @Tecnativa TT63153
ping @sergio-teruel @carlosdauden