Skip to content

[IMP] Move the constraint on uniqueness for cutoff date at line level using a configuration - #343

Closed
lmarion-source wants to merge 2 commits into
OCA:16.0from
acsone:16.0-multiple_cutoff
Closed

lmarion-source wants to merge 2 commits into
OCA:16.0from
acsone:16.0-multiple_cutoff

Conversation

@lmarion-source

Copy link
Copy Markdown
  • Add the possibility to create several cutoff with the same date

If the box is not checked in configurations, the uniqueness is checked at the cutoff level (as previously done). If we need to create several cutoff at the same date for different journals/accounts, we can check the box and the check will be done at the cutoff line level.

Business case can be :

  • One user (A) creates a cutoff for some account moves. Another user (B) creates other moves, then wants to see those moves in a cutoff.
    However, B does not want to interfere with the cutoff A already made. B creates a new cutoff with the same date as the one of A, and when he generates lines,
    only retrieves the one that were not already in the cutoff of A.

  • One user wants to create several cutoff at the same date, but for different journals/accounts

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @jbaudoux, @alexis-via,
some modules you are maintaining are being modified, check this out!

@lmarion-source

Copy link
Copy Markdown
Author

@jbaudoux I was not able to re-open the #310 so I did a new one and add a configuration for the business case I have. This way the original behaviour stays the same

@acsonefho acsonefho left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jbaudoux jbaudoux left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to make one commit per module

Comment thread account_cutoff_base/migrations/16.0.1.5.1/post-migrate.py
Comment thread account_cutoff_base/models/account_cutoff_line.py Outdated
Lindsay added 2 commits September 15, 2025 11:23
…ff date at line level + Add the possibility to create several cutoff with the same date + Add a configuration to check cutoff date unicity either on lines or on the whole cutoff

Business case can be :

- One user (A) creates a cutoff for some account moves. Another user (B) creates other moves, then wants to see those moves in a cutoff.
      However, B does not want to interfere with the cutoff A already made. B creates a new cutoff with the same date as the one of A, and when he generates lines,
      only retrieves the one that were not already in the cutoff of A.

- One user wants to create several cutoff at the same date, but for different journals/accounts
…toff date unicity either on lines or on the whole cutoff
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants