Skip to content

Test oai-spec-test package checkout layout - #14

Merged
handrews merged 1 commit into
OAI:mainfrom
handrews:oai-spec-test
Aug 6, 2026
Merged

Test oai-spec-test package checkout layout#14
handrews merged 1 commit into
OAI:mainfrom
handrews:oai-spec-test

Conversation

@handrews

@handrews handrews commented Aug 4, 2026

Copy link
Copy Markdown
Member

Ensure oai-spec-test works in developer mode. Existing tests for it use the installed package layout.

Co-authored-by: Codex <codex@openai.com>
@miqui

miqui commented Aug 6, 2026

Copy link
Copy Markdown

@handrews

my review:

Verified:

  • Checked out the branch, ran npm install + npx vitest run — all 10 test files / 25 tests pass, including the new one.
  • The fixture is correctly targeted: bin/oai-spec-test resolves c8/vitest via createRequire(import.meta.url), so Node's resolution walks up from the script's own directory — this test's root/node_modules fixture is genuinely a different resolution path than the nested-consumer fixture in bin-resolution.test.mjs, so it's not redundant coverage.
  • Assertions check both the c8 --100 invocation and the vitest ... run --coverage --runInBand invocation, which is what actually distinguishes this from a broken resolution path.
  • Temp-dir cleanup via afterEach matches the pattern already used in the other 6 test files with this same boilerplate (bin-resolution.test.mjs, release-commands.test.mjs, etc.) — no new duplication pattern introduced, just following existing convention.

findings: none, well put together.

@miqui

miqui commented Aug 6, 2026

Copy link
Copy Markdown

@handrews repo perms, can't provide a PR review.

@handrews
handrews merged commit fc6c089 into OAI:main Aug 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants