-
Notifications
You must be signed in to change notification settings - Fork 9.1k
3.2: removes the OAS reference object from headers schema definition #4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.2: removes the OAS reference object from headers schema definition #4663
Conversation
…nd media type schema/item schema Signed-off-by: Vincent Biret <[email protected]>
The alternative I've considered would be to remove reference object from the headers schema fixed fields, so it relies on the JSON schema reference mechanisms. This would be a better alternative IMHO but I wanted to get feedback first. Happy to update the PR. |
I don't think this is correct. The definition for "schema" already includes (edited to add, after your second comment:) Consistency is good, so I agree with your other option that we remove the -or-reference bits from the other definitions that have them. |
Signed-off-by: Vincent Biret <[email protected]>
@ralfhandl I think I have enough approvals for merge, but I don't have the merge permission. Also do you want me to put together a PR to target 3.1 ? |
Sorry, this one has a conflict now, could you take another look @baywet ? |
Signed-off-by: Vincent Biret <[email protected]>
5ad551d
merged the conflicts @lornajane! This should be good to review again/merge. |
Also, I won't be opening a PR to 3.1 as it seems this has already been fixed. |
This is now blocked by a missing test case for a schema feature added by This will be fixed by |
I noticed the reference option was missing for the schema/item schema of parameter and media type, this PR addresses the oversight and will probably need to be back-ported to 3.1EDIT: thanks to @karenetheridge input, I opted for the better alternative, to remove the OAS reference object from headers schema since that can rely on JSON schema ref instead.