Skip to content

v3.2: makes the versioning and deprecation non-breaking for minor versions #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Jun 5, 2025

motivation: having 3.1 being a minor version on paper but in reality bringing a lot of breaking changes caused confusion and friction for consumers, tools implementers etc...
This is partly due because nowadays, a lot of the industry is following, and expects others to follow semver.
This pull request updates the verbiage of the versioning and deprecation policies so it forbids making breaking changes in minor/patch versions, so we can conform to semver, after 3.1.

@baywet baywet requested review from a team as code owners June 5, 2025 17:45
@handrews handrews added Process editorial Wording and stylistic issues labels Jun 5, 2025
@handrews handrews added this to the v3.2.0 milestone Jun 5, 2025
@handrews handrews changed the title docs: makes the versioning and deprecation non-breaking for minor versions v3.2: makes the versioning and deprecation non-breaking for minor versions Jun 5, 2025
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not in favour of this change.

Additionally, I find it particularly unhelpful for it to be proposed at the end of a development cycle which has been worked on under different constraints. Hard no from me.

See also #2415

@lornajane lornajane requested a review from a team June 5, 2025 18:42
@baywet
Copy link
Contributor Author

baywet commented Jun 5, 2025

I am not in favour of this change.

@lornajane besides the reasons articulated in the linked issue, do you have additional reasons why you're against such a change?

Additionally, I find it particularly unhelpful for it to be proposed at the end of a development cycle which has been worked on under different constraints. Hard no from me.

What do you encompass as the development cycle here? 3.2? 3.X?

  • In the case of 3.X, well, I wasn't here at the time :)
  • In the case of 3.2, I've submitted this PR against that branch to start with, but if this ends up being accepted, I suggest we backport it to 3.1 as well.

Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section only expresses what the current TSC hopes a future TSC will or will not do. A future TSC can completely ignore and rephrase it. Making the text more restrictive doesn’t change this fact.

The current text reflects what past TSCs have done after serious deliberations, and I prefer to keep it as is to (a) honor the tough decision they made and (b) give the same freedom and responsibility to future TSCs.

@ralfhandl ralfhandl requested a review from a team June 6, 2025 10:36
@handrews
Copy link
Member

handrews commented Jun 9, 2025

That's two solid "no" votes from the TSC, so I'm going to close this.

@handrews handrews closed this Jun 9, 2025
@baywet baywet deleted the fix/non-breaking-minors branch June 10, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Wording and stylistic issues Process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants