Major overhaul of documentation#84
Merged
Merged
Conversation
b8c9b1d to
d6a92ef
Compare
d6a92ef to
e0a28ad
Compare
2bce053 to
a7e74e8
Compare
maximilian-gelbrecht
approved these changes
Apr 7, 2026
Collaborator
maximilian-gelbrecht
left a comment
There was a problem hiding this comment.
I won't have time to look over everything today, and somehow it doesn't work well to only show me the differences to the last review. Anyway, I am sure everything is good to merge, because it was already in a really good state before, and any small things that might still come up we can also just address in follow ups.
Also adds constant value initializer for soil saturation
This is a temporary fix, we should come up with a better solution for handling input files that doesn't rely so much on the working directory.
CI on GitHub runs on CPU which takes way too long to simulate 30 days at 1 degree resolution.
Collaborator
Author
|
All green again ✔️ 🎉 Like @maximilian-gelbrecht said, we can continue fixing small things in follow up PRs. @matteo-willeit maybe you can take another look at the published documentation after this is merged. Thanks @mahabadri for taking the time to work on the vegetation docs and @matteo-willeit for all the great feedback! |
Collaborator
|
Sure, I will have a look when I'm back from vacation next Monday. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #69
This PR reorganizes, update, and expands the documentation on Terrarium's core interfaces and currently implemented processes.
TODO list:
closure!andinvclosure!auxiliaryvariable initializer interface)https://numericalearth.github.io/Terrarium.jl/previews/PR84/