Soil Heat Diffusion Example (#91)

[elenamiralles]

Add soil heat diffusion example with analytical validation

Closes #91

[bgroenks96]

Looks like a good start, thanks! I left a few comments below.

I am also interested in hearing your feedback; did you run into any issues? Was anything confusing for you or missing clear documentation?

[elenamiralles]

Hi @bgroenks96, thank you for the review. I will update the code asap. With respect to documentation everything was very straightforward! One thing that I think could use some improvement is time to download? Maybe it was just my machine but it took 20 min to import the Terrarium package initially.

[bgroenks96]

One thing that I think could use some improvement is time to download? Maybe it was just my machine but it took 20 min to import the Terrarium package initially.

That's not good! Do you mean the initial installation of the package? That can definitely be slow in Julia due to precompilation time, but 20 minutes seems excessive to me, unless your internet connection was quite slow.

[elenamiralles]

Yes, it was the initial installation! I also was surprised by how long it took. It could have been my internet connection but I've not had that problem with other packages yet.

[bgroenks96]

Hey @elenamiralles, sorry for the long silence. The last few weeks were a bit hectic with a lot of traveling, but I'm back now. I think this looks generally good. I updated the branch with the latest changes from main and merged your example script with the existing soil heat column example in 65dd159. I think this makes sense because they are anyway the same basic model setup.

Is there anything else you'd like to add here? One thing that might be nice is testing against the analytical solution to the Stefan problem, but we don't necessarily have to do that in this PR.

[elenamiralles]

Hey @bgroenks96!

No worries, I figured that was the case. Glad it looked good! I'd be happy to test it against the Stephan problem too if you think that would be helpful. I'll try to brainstorm some more ideas and let you know if I come up with anything.