Allow package update to use specific version #6497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
commented
Jun 10, 2025
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommand.cs
Outdated
Show resolved
Hide resolved
nkolev92
reviewed
Jun 10, 2025
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/Package.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/Package.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/Package.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommand.cs
Outdated
Show resolved
Hide resolved
donnie-msft
reviewed
Jun 10, 2025
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/Package.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.Tests/NuGet.CommandLine.Xplat.Tests/Commands/Package/Update/PackageTests.cs
Show resolved
Hide resolved
...ne.Xplat.Tests/Commands/Package/Update/PackageUpdateCommandRunner.GetPackageToUpdateTests.cs
Show resolved
Hide resolved
...ne.Xplat.Tests/Commands/Package/Update/PackageUpdateCommandRunner.GetPackageToUpdateTests.cs
Show resolved
Hide resolved
test/NuGet.Core.Tests/NuGet.CommandLine.Xplat.Tests/Commands/Package/Update/PackageTests.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/PackageUpdateCommandRunner.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Package/Update/Package.cs
Show resolved
Hide resolved
nkolev92
approved these changes
Jun 11, 2025
jeffkl
approved these changes
Jun 11, 2025
zivkan
force-pushed
the
dev-zivkan-update-version
branch
from
0a05dc9 to
17a46ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14306
Description
Allow
dotnet package updateto update to a specific version using thepackageId@versionsyntax thatdotnet package addalready supports (possibly dotnet tool install as well). It also supports version ranges, in case that's what the customer wants in their project file. For example,dotnet package update "Contoso.Utils@[1.2.3, 2.0.0)".The package@version parsing is done in the CLI parser, so that when there's an error, the CLI parser can do error handling (after all, it's an input error).
Made the version chooser mockable, so that the logic to decide if the package source should be queried can be tested without needing a real package source.
PR Checklist