Add support for high quality and responsive Youtube preview images #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
@onnimonni this looks great! in the future, please run prettier and make sure tests pass https://github.com/NotionX/react-notion-x/actions/runs/11785318289/job/32826328578?pr=582 I'll fix locally for now. |
Contributor
Author
Thanks and sorry about that 🙇 I'll try to check that it would do it automatically on commits in the future 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I asked feedback about my website and my friend shared great point that the default Youtube preview images are quite blurry.
I learned how img srcsets work and added support for high quality alternative
webpphotos.I tested this on locally with chrome and it skips completely the default jpg and preloads only the highest available image on desktop.
Notion Test Page ID
0f7d9b7aec8b4d16a064886b245badef
Preview images
This is how it currently looks in production at https://keksi.io
This is how it looks in my localhost:3000