Skip to content

fix: make sure loading widget hides when ReadiumReaderWidget is done - #217

Merged
ddfreiling merged 3 commits into
Notalib:mainfrom
mtmse:fix/loading-icon-stays
Sep 1, 2026
Merged

fix: make sure loading widget hides when ReadiumReaderWidget is done#217
ddfreiling merged 3 commits into
Notalib:mainfrom
mtmse:fix/loading-icon-stays

Conversation

@AndreasLymalmMTM

Copy link
Copy Markdown
Contributor

Description

Any loading widget passed to ReadiumReaderWidget stayed above the content after loading completed, often just less than a second, but in rare cases it stayed indefinitely.

The solution in this PR is to listen on the initial content being visually ready (with the new onReaderReady), instead of onPageChanged.

Before -> After

loading-widget-stay.mp4
loading-widget-hide.mp4

@ddfreiling

Copy link
Copy Markdown
Member

Thanks @AndreasLymalmMTM. There seem to be an iOS integration test failing now. Can you run the integration tests locally and debug that?

@m-abs

m-abs commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

@AndreasLymalmMTM can you also merge main into this?

@AndreasLymalmMTM

Copy link
Copy Markdown
Contributor Author

@ddfreiling @m-abs I'm on it!

@ddfreiling

Copy link
Copy Markdown
Member

All iOS integration tests pass fine for this branch on my local machine, may be just a GH runner timing fluke

@AndreasLymalmMTM

Copy link
Copy Markdown
Contributor Author

All iOS integration tests pass fine for this branch on my local machine, may be just a GH runner timing fluke

Yeah, that's what Copilot thought too when dianogsing the failing test. Let's see how it goes.

@ddfreiling

Copy link
Copy Markdown
Member

These GH iOS runner are entirely unreliable. Merging this, thanks for catching this @AndreasLymalmMTM 🥇

@ddfreiling
ddfreiling merged commit 486c593 into Notalib:main Sep 1, 2026
13 of 14 checks passed
@AndreasLymalmMTM

Copy link
Copy Markdown
Contributor Author

These GH iOS runner are entirely unreliable. Merging this, thanks for catching this @AndreasLymalmMTM 🥇

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants