-
-
Notifications
You must be signed in to change notification settings - Fork 158
languages/typst: Add inline preview via typst-concealer #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A very quick entry would be nice.
Sure, you can set them as its done in many module. See telescope for an example.
Option descriptions are usually from plugin documentation in our case. You're free to change them, but I'm not going to ask you to.
Leaving setupOpts empty means plugin's defaults will be used (if the plugin sets them.) Up to you whether you think some defaults are more... equal than others. |
Co-authored-by: raf <[email protected]>
02ee4cc
to
bc978c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming you tested it and it works fine, this LGTM. Just need to fix conflicts with main @PartyWumpus
oh and yes i've tested this locally with |
Please add it to the typos config so that the CI doesn't get triggered each time we commit to the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Thank you wumpus :) |
✅ Preview has been deleted successfully! |
Adds the typst-concealer plugin for displaying typst inline.
This is marked as draft because I'm not sure about:
null
and letting the plugin pick?