Conversation
0.4 has not been released yet so use the latest commit from the develop branch instead.
Use asynchronous spawn cache in pogeo.monotools.
Remove dependence on shapely and geopy, improve performance of landmarks, automate landmark pickling/unpickling, read landmarks from config as a sequence of dicts instead of a Landmarks object, a little refactoring, miscellaneous fixes.
Add an example script for converting old-style landmarks configurations (constructing an actual Landmarks instance in config.py) with the new-style of using standard Python data-types (a tuple/list of dicts).
c
Merge master
6304
adding cp
adding cp
Correction CP
CP
Adding lure on demand
LURE_ON_DEMAND default false
Define LURE_ON_DEMAND
Encounter only if player level >= 30
Clean branch
monocle/worker.py
Outdated
| or (encounter_conf == 'some' | ||
| and normalized['pokemon_id'] in conf.ENCOUNTER_IDS)): | ||
| and normalized['pokemon_id'] in conf.ENCOUNTER_IDS)) | ||
| and self.player_level != None and self.player_level >= 30: |
There was a problem hiding this comment.
the closing ) should be at the end of this line
There was a problem hiding this comment.
Could add an other () but not moving ) after self.player_level >= 30.
|
and could you maybe cleanup your branch? a single commit would be nice |
Adding ()
| or (encounter_conf == 'some' | ||
| and normalized['pokemon_id'] in conf.ENCOUNTER_IDS)): | ||
| and normalized['pokemon_id'] in conf.ENCOUNTER_IDS)) | ||
| and self.player_level != None and self.player_level >= 30): |
There was a problem hiding this comment.
Cool, but doesn't this mean that if there is no level 30 worker nearby it just won't encounter?
There was a problem hiding this comment.
In fact we shouldn't encounter with a bot less than lvl30 because IV and CPs are same just for lvl30+
There was a problem hiding this comment.
As long as information is sent to webooks even if no encounter happened.
So we atleast can get notified of a pokemon with no IV info, than no pokemon at all.
There was a problem hiding this comment.
No encounter doesn't mean no pokemon...
Encounter is used to get IV, CP and moves
evenly-epic-mule
left a comment
evenly-epic-mule
left a comment
There was a problem hiding this comment.
and please make it one commit :)
| or (encounter_conf == 'some' | ||
| and normalized['pokemon_id'] in conf.ENCOUNTER_IDS)): | ||
| and normalized['pokemon_id'] in conf.ENCOUNTER_IDS)) | ||
| and self.player_level != None and self.player_level >= 30): |
There was a problem hiding this comment.
self.player_level and self.player_level >= 30sould be fine too, you don't need the check if it is!= None- I now understand it maybe it would be better this way:
if (self.player_level and self.player_level >= 30 and
((encounter_conf == 'some' and normalized['pokemon_id'] in conf.ENCOUNTER_IDS)
or encounter_conf == 'all')):
or something like that
|
Problem is that if i.e a snorlax is found with a non-LV30 worker then we'll never have the IV ? |
|
How do you see where the pokemon are. Like the actual radar. I'm on mobile right now. I don't know where to go to find the actual radar. Please help. |
j16sdiz
left a comment
j16sdiz
left a comment
There was a problem hiding this comment.
Doesn't line 804 need the same change?
8 participants
Limiting encounters to bots that are lvl30 or more