Map: Reset Spawnpoints after migration#234
Open
evenly-epic-mule wants to merge 1 commit intoNoctem:developfrom
Open
Map: Reset Spawnpoints after migration#234evenly-epic-mule wants to merge 1 commit intoNoctem:developfrom
evenly-epic-mule wants to merge 1 commit intoNoctem:developfrom
Conversation
Noctem
requested changes
May 3, 2017
| 'spawn_id': spawn.spawn_id, | ||
| 'despawn_time': spawn.despawn_time, | ||
| 'despawn_time': spawn.despawn_time | ||
| if spawn.updated and spawn.updated > conf.LAST_MIGRATION else None, |
Owner
There was a problem hiding this comment.
I'd say truth-testing spawn.updated before the comparison isn't necessary. The default migration time isn't zero and if someone wants to disable migration checks entirely they should set LAST_MIGRATION to 1 or any time before their first scan. So with a valid configuration spawn.updated > conf.LAST_MIGRATION should always fail when spawn.updated fails the truth test.
Contributor
Author
There was a problem hiding this comment.
after removing the spawn.updated and I get TypeError: unorderable types: NoneType() > int()
guess I'll have to readd it
evenly-epic-mule
force-pushed
the
map_fix_unknown_spawn
branch
from
c4a6aec to
0a2ed10
Compare
Marking not jet updated spawns as mysteries again
evenly-epic-mule
force-pushed
the
map_fix_unknown_spawn
branch
from
0a2ed10 to
b9793ef
Compare
RobTwoThree
pushed a commit
to RobTwoThree/Monocle
that referenced
this pull request
Dec 25, 2017
Cleaned up duplicate and unused imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking not jet updated spawns as mysteries again