Make preview tasks a cleanroom, stock editor plus this plugin#127
Closed
alerque wants to merge 1 commit intoNoahTheDuke:mainfrom
Closed
Make preview tasks a cleanroom, stock editor plus this plugin#127alerque wants to merge 1 commit intoNoahTheDuke:mainfrom
alerque wants to merge 1 commit intoNoahTheDuke:mainfrom
Conversation
There are currently quite a few ways for user configs to leak into this and change how the plugin responds. Notably if the user has vim-polyglot or anything else that does Justfile stuff to start with, these preview tasts will not actually show what *this* plugin is doing. This should be much more robust, including leaving the editor to actually *want* to load the plugin as a result of normal actions like how it does file type detection, not forcing the plugin to be loaded before testing begins.
Collaborator
|
Loading user configuration is intentional and the current preview recipes go out of their way and put a lot of effort to retain this behavior. We could add separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are currently quite a few ways for user configs to leak into this and change how the plugin responds. Notably if the user has vim-polyglot or anything else that does Justfile stuff to start with, these preview tasts will not actually show what this plugin is doing.
This should be much more robust, including leaving the editor to actually want to load the plugin as a result of normal actions like how it does file type detection, not forcing the plugin to be loaded before testing begins. This is especially useful for testing the file type detection itself.