Skip to content

Feat/alpaca#1384

Draft
xsa-dev wants to merge 4 commits intoNoFxAiOS:devfrom
xsa-dev:feat/alpaca
Draft

Feat/alpaca#1384
xsa-dev wants to merge 4 commits intoNoFxAiOS:devfrom
xsa-dev:feat/alpaca

Conversation

@xsa-dev
Copy link
Contributor

@xsa-dev xsa-dev commented Feb 15, 2026

Pull Request

📋 Choose Specialized Template

We now offer specialized templates for different types of PRs to help you fill out the information faster:

How to use?

  • When creating a PR, add ?template=backend.md or other template name to the URL
  • Or simply copy and paste the content from the corresponding template

💡 Tip: Recommended PR title format type(scope): description
Example: feat(trader): add new strategy | fix(api): resolve auth issue


📝 Description


🎯 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📝 Documentation update
  • 🎨 Code style update
  • ♻️ Refactoring
  • ⚡ Performance improvement
  • ✅ Test update
  • 🔧 Build/config change
  • 🔒 Security fix

🔗 Related Issues

  • Closes #
  • Related to #

📋 Changes Made


🧪 Testing

  • Tested locally
  • Tests pass
  • Verified no existing functionality broke

✅ Checklist

Code Quality

  • Code follows project style
  • Self-review completed
  • Comments added for complex logic

Documentation

  • Updated relevant documentation

Git

  • Commits follow conventional format
  • Rebased on latest dev branch
  • No merge conflicts

📚 Additional Notes


By submitting this PR, I confirm:


🌟 Thank you for your contribution!

- Add new translation keys for all hardcoded Chinese strings
- Replace hardcoded UI text with t('key', language) calls
- Support both English and Chinese languages

Modified files:
- web/src/i18n/translations.ts: +88 lines (42 new keys)
- web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings
- Fix Alpaca crypto API URL from v1beta1 to v1beta3
- Add crypto symbol validation with cache
- Make symbol validation non-blocking to avoid 500 errors
- Return proper 400 errors for unsupported symbols and missing keys
@github-actions
Copy link

🤖 Advisory Check Results

These are advisory checks to help improve code quality. They won't block your PR from being merged.

📋 PR Information

Title Format: ⚠️ Suggestion - Consider using type(scope): description

Recommended format

Valid types: feat, fix, docs, style, refactor, perf, test, chore, ci, security, build

Examples:

  • feat(trader): add new trading strategy
  • fix(api): resolve authentication issue
  • docs: update README

PR Size: 🔴 Large (1368 lines: +1236 -132)

💡 Suggestion: This is a large PR. Consider breaking it into smaller, focused PRs for easier review.

🔧 Backend Checks

Go Formatting: ⚠️ Needs formatting

Files needing formatting
api/strategy.go
api/utils_test.go
backtest/aicache.go
backtest/config.go
backtest/types.go
debate/engine.go
experience/experience.go
kernel/engine.go
kernel/formatter.go
kernel/grid_engine.go

Go Vet: ✅ Good
Tests: ✅ Passed

Fix locally:

go fmt ./...      # Format code
go vet ./...      # Check for issues
go test ./...     # Run tests

⚛️ Frontend Checks

Build & Type Check: ✅ Success

Fix locally:

cd web
npm run build  # Test build (includes type checking)

📖 Resources

Questions? Feel free to ask in the comments! 🙏


These checks are advisory and won't block your PR from being merged. This comment is automatically generated from pr-checks-run.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant