Skip to content

Add browser extension icons to source control#343

Open
JasperNoBoxDev wants to merge 1 commit intomainfrom
add-browser-extension-icons
Open

Add browser extension icons to source control#343
JasperNoBoxDev wants to merge 1 commit intomainfrom
add-browser-extension-icons

Conversation

@JasperNoBoxDev
Copy link
Copy Markdown
Contributor

Summary

  • Browser extension icons (16×16, 32×32, 48×48, 128×128 PNG) were present locally but untracked in git
  • manifest-chrome.json and manifest-firefox.json both reference these icons
  • build.sh copies them to dist/icons/ on each build — without them committed, a fresh clone would produce a broken extension build

Test plan

  • Verify browser-extension/icons/ contains all 4 PNG files after checkout
  • Run bash build.sh — confirms icons copy to dist/icons/ without errors

🤖 Generated with Claude Code

Icons were present locally and referenced in manifest-chrome.json/manifest-firefox.json
but had never been committed. Build script copies them to dist/ on each build.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • browser-extension/icons/icon-128.png is excluded by !**/*.png
  • browser-extension/icons/icon-16.png is excluded by !**/*.png
  • browser-extension/icons/icon-32.png is excluded by !**/*.png
  • browser-extension/icons/icon-48.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5417569a-2d8a-40ad-9ab7-9e7f1eca582d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-browser-extension-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant