nixos/netbird-relay: init module - #559588
Open
woile wants to merge 1 commit into
Open
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
woile
force-pushed
the
feat/netbird-relay
branch
from
September 3, 2026 16:57
fb82dfc to
d33589f
Compare
woile
force-pushed
the
feat/netbird-relay
branch
from
September 4, 2026 06:07
d33589f to
f2c5574
Compare
10 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/7518 |
h7x4
added
8.has: module (new)
PatrickDaG
approved these changes
Sep 9, 2026
PatrickDaG
left a comment
PatrickDaG
left a comment
Contributor
There was a problem hiding this comment.
Some miscellaneous improvements but nothing major or imo necessarily blocking.
LGTM.
The review was aided by AI(GPT-5.6-sol), I have checked everything myself, if I missed anything I am very sorry. All text was written by me.
nixpkgs-ci
Bot
added
the
12.approvals: 1
Contributor
Author
|
Thanks @PatrickDaG for the review. I'm on holiday so I'll fix the missing comments next week. (Unless someone wants to merge this and send a new PR) |
woile
force-pushed
the
feat/netbird-relay
branch
from
September 13, 2026 09:03
f2c5574 to
e172825
Compare
woile
force-pushed
the
feat/netbird-relay
branch
from
September 13, 2026 09:16
e172825 to
c3472d0
Compare
Contributor
Author
|
@PatrickDaG can you take another look? I've fixed all the comments. If you think it's good could you tag someone with merge? thanks |
Contributor
|
LGTM |
PatrickDaG
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.This PR introduces an independent Netbird Relay under:
services.netbird.relay.I didn't want to introduce it under
services.netbird.server.relaybecause Netbird actually has a newservercomponent which includes a relay (it also uses a YAML config). Which is the direction I think we should follow. So to prevent a future conflict, I wanted to keep it independent from the beginning.Furthermore, this component can be run in isolation, an operator may want to run 1 or more relays and feed them to the control plane, whether the
serverthing I mentioned before is developed or not.