python3Packages.pyfaidx: 0.9.0.3 -> 0.9.0.4; python3Packages.cnvkit: 0.9.12 -> 0.9.13#517438
Open
SkohTV wants to merge 4 commits into
Open
python3Packages.pyfaidx: 0.9.0.3 -> 0.9.0.4; python3Packages.cnvkit: 0.9.12 -> 0.9.13#517438SkohTV wants to merge 4 commits into
SkohTV wants to merge 4 commits into
Conversation
nixpkgs-ci
Bot
added
8.has: package (update)
SkohTV
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
SkohTV
added
the
0.kind: ZHF Fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZHF: #516381
python3Packages.pyfaidx
https://github.com/mdshw5/pyfaidx/releases/tag/v0.9.0.4
The files that were tested (
Anomala_cuprea_entomopoxvirus.faa.gz,genes.fasta,genes.fasta.lowerandissue_141.fasta) are not in the repo anymore and must be downloaded via a script (require network access).We can either:
genes.fasta, 47Ki) and skip the tests for the others (4 tests)I went for the first one, but I'm open to other opinions.
python3Packages.cnvkit
Removed the old (now merged) patch
A new fetchpatch was required for another more recent patch fixing a testing issue
Opened etal/cnvkit#1048 upstream regarding
pyparsingdependency relaxation (our version is>3.3.0)Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.