You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
CFLAGS = None
CARGO_ENCODED_RUSTFLAGS = Some(-C�target-feature=-crt-static)
cargo:warning=Warning: supplying the --target x86_64-apple-macosx != x86_64-apple-darwin argument to a nix-wrapped compiler may not work correctly - cc-wrapper is currently not designed with multi-target compilers in mind. You may want to use an un-wrapped compiler instead.
cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3HBMBG7RG1DM5/Cocoa-1OAIM8QTB2UTV.pcm': 'No such file or directory'
cargo:warning=In file included from objc/notify.m:1:
cargo:warning=objc/notify.h:1:9: fatal error: could not build module 'Cocoa'
cargo:warning= 1 | #import
cargo:warning= | ~~~~~~~^
cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3HBMBG7RG1DM5/CoreServices-VPKCXQNMS1KE.pcm': 'No such file or directory'
cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3HBMBG7RG1DM5/Foundation-LIZ6888D0WO3.pcm': 'No such file or directory'
cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3HBMBG7RG1DM5/ObjectiveC-21EN614CLIH3H.pcm': 'No such file or directory'
cargo:warning=5 errors generated.
--- stderr
error occurred in cc-rs: Command env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "/nix/store/cm1kj0v0xpsql7fww3hv7f3z930k2fnw-clang-wrapper-19.1.7/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "--target=x86_64-apple-macosx" "-mmacosx-version-min=11.3" "-Wall" "-Wextra" "-fmodules" "-Wno-deprecated-declarations" "-mmacos-version-min=11.3" "-o" "/private/tmp/nix-build-nu_plugin_desktop_notifications-1.2.11-unstable-2025-05-05.drv-1/source/target/x86_64-apple-darwin/release/build/mac-notification-sys-e2355c850adf0796/out/54532c69c7c8f551-notify.o" "-c" "objc/notify.m" with args cc did not execute successfully (status code exit status: 1).
warning: build failed, waiting for other jobs to finish...
CFLAGS = None
CARGO_ENCODED_RUSTFLAGS = Some(-C�target-feature=-crt-static)
cargo:warning=Warning: supplying the --target arm64-apple-macosx != arm64-apple-darwin argument to a nix-wrapped compiler may not work correctly - cc-wrapper is currently not designed with multi-target compilers in mind. You may want to use an un-wrapped compiler instead.
cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/VPZ41XWYX6HD/Cocoa-386NJX2G9ZHA4.pcm': 'No such file or directory'
cargo:warning=In file included from objc/notify.m:1:
cargo:warning=objc/notify.h:1:9: fatal error: could not build module 'Cocoa'
cargo:warning= 1 | #import
cargo:warning= | ~~~~~~~^
cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/VPZ41XWYX6HD/CoreServices-P7HEQGQ3R0EP.pcm': 'No such file or directory'
cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/VPZ41XWYX6HD/Foundation-2QP4YOA87HD1H.pcm': 'No such file or directory'
cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/VPZ41XWYX6HD/ObjectiveC-7ITS4SEVUITZ.pcm': 'No such file or directory'
cargo:warning=5 errors generated.
--- stderr
error occurred in cc-rs: Command env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "/nix/store/cvhbqa01i5yy7xmmpqp1hbnvq7kpvgsx-clang-wrapper-19.1.7/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-macosx" "-mmacosx-version-min=11.3" "-Wall" "-Wextra" "-fmodules" "-Wno-deprecated-declarations" "-mmacos-version-min=11.3" "-o" "/private/tmp/nix-build-nu_plugin_desktop_notifications-1.2.11-unstable-2025-05-05.drv-0/source/target/aarch64-apple-darwin/release/build/mac-notification-sys-961b12e192365559/out/54532c69c7c8f551-notify.o" "-c" "objc/notify.m" with args cc did not execute successfully (status code exit status: 1).
warning: build failed, waiting for other jobs to finish...
Ok, so the problem was building it sandboxed for darwin. While it works, I do not know how to specify that in the package. Is there anything I have to do to specify that this can not be built sandboxed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds nu_desktop_notifications as a nushell plugin.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.