Skip to content

nushellPlugins.desktop-notifications: init at 1.2.11#416331

Closed
aldenparker wants to merge 1 commit intoNixOS:masterfrom
aldenparker:add-nu-plugin-desktop-notifications
Closed

nushellPlugins.desktop-notifications: init at 1.2.11#416331
aldenparker wants to merge 1 commit intoNixOS:masterfrom
aldenparker:add-nu-plugin-desktop-notifications

Conversation

@aldenparker
Copy link
Contributor

Adds nu_desktop_notifications as a nushell plugin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@aldenparker
Copy link
Contributor Author

Originally built and tested using nixos-25.05, so please add backport release-25.05 label to this.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 13, 2025
@aldenparker aldenparker force-pushed the add-nu-plugin-desktop-notifications branch 2 times, most recently from 4947735 to d3ac63a Compare June 13, 2025 05:14
@aldenparker aldenparker force-pushed the add-nu-plugin-desktop-notifications branch from d3ac63a to d69d82c Compare June 13, 2025 15:02
@wolfgangwalther
Copy link
Contributor

Re-running CI due to a odd failure fixed in #416448

@PerchunPak
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416331
Commit: d69d82c549c4cf5a8a6f1d5bbedd4be4e9b75d0b


x86_64-linux

✅ 1 package built:
  • nushellPlugins.desktop-notifications

aarch64-linux

✅ 1 package built:
  • nushellPlugins.desktop-notifications

x86_64-darwin

❌ 1 package failed to build:
  • nushellPlugins.desktop-notifications

aarch64-darwin

❌ 1 package failed to build:
  • nushellPlugins.desktop-notifications

Error logs: `x86_64-darwin`
nushellPlugins.desktop-notifications
  CFLAGS = None
  CARGO_ENCODED_RUSTFLAGS = Some(-C�target-feature=-crt-static)
  cargo:warning=Warning: supplying the --target x86_64-apple-macosx != x86_64-apple-darwin argument to a nix-wrapped compiler may not work correctly - cc-wrapper is currently not designed with multi-target compilers in mind. You may want to use an un-wrapped compiler instead.
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3HBMBG7RG1DM5/Cocoa-1OAIM8QTB2UTV.pcm': 'No such file or directory'
  cargo:warning=In file included from objc/notify.m:1:
  cargo:warning=objc/notify.h:1:9: fatal error: could not build module 'Cocoa'
  cargo:warning=    1 | #import 
  cargo:warning=      |  ~~~~~~~^
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3HBMBG7RG1DM5/CoreServices-VPKCXQNMS1KE.pcm': 'No such file or directory'
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3HBMBG7RG1DM5/Foundation-LIZ6888D0WO3.pcm': 'No such file or directory'
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3HBMBG7RG1DM5/ObjectiveC-21EN614CLIH3H.pcm': 'No such file or directory'
  cargo:warning=5 errors generated.

--- stderr

error occurred in cc-rs: Command env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "/nix/store/cm1kj0v0xpsql7fww3hv7f3z930k2fnw-clang-wrapper-19.1.7/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "--target=x86_64-apple-macosx" "-mmacosx-version-min=11.3" "-Wall" "-Wextra" "-fmodules" "-Wno-deprecated-declarations" "-mmacos-version-min=11.3" "-o" "/private/tmp/nix-build-nu_plugin_desktop_notifications-1.2.11-unstable-2025-05-05.drv-1/source/target/x86_64-apple-darwin/release/build/mac-notification-sys-e2355c850adf0796/out/54532c69c7c8f551-notify.o" "-c" "objc/notify.m" with args cc did not execute successfully (status code exit status: 1).

warning: build failed, waiting for other jobs to finish...


Error logs: `aarch64-darwin`
nushellPlugins.desktop-notifications
  CFLAGS = None
  CARGO_ENCODED_RUSTFLAGS = Some(-C�target-feature=-crt-static)
  cargo:warning=Warning: supplying the --target arm64-apple-macosx != arm64-apple-darwin argument to a nix-wrapped compiler may not work correctly - cc-wrapper is currently not designed with multi-target compilers in mind. You may want to use an un-wrapped compiler instead.
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/VPZ41XWYX6HD/Cocoa-386NJX2G9ZHA4.pcm': 'No such file or directory'
  cargo:warning=In file included from objc/notify.m:1:
  cargo:warning=objc/notify.h:1:9: fatal error: could not build module 'Cocoa'
  cargo:warning=    1 | #import 
  cargo:warning=      |  ~~~~~~~^
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/VPZ41XWYX6HD/CoreServices-P7HEQGQ3R0EP.pcm': 'No such file or directory'
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/VPZ41XWYX6HD/Foundation-2QP4YOA87HD1H.pcm': 'No such file or directory'
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/VPZ41XWYX6HD/ObjectiveC-7ITS4SEVUITZ.pcm': 'No such file or directory'
  cargo:warning=5 errors generated.

--- stderr

error occurred in cc-rs: Command env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "/nix/store/cvhbqa01i5yy7xmmpqp1hbnvq7kpvgsx-clang-wrapper-19.1.7/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-macosx" "-mmacosx-version-min=11.3" "-Wall" "-Wextra" "-fmodules" "-Wno-deprecated-declarations" "-mmacos-version-min=11.3" "-o" "/private/tmp/nix-build-nu_plugin_desktop_notifications-1.2.11-unstable-2025-05-05.drv-0/source/target/aarch64-apple-darwin/release/build/mac-notification-sys-961b12e192365559/out/54532c69c7c8f551-notify.o" "-c" "objc/notify.m" with args cc did not execute successfully (status code exit status: 1).

warning: build failed, waiting for other jobs to finish...

@aldenparker aldenparker force-pushed the add-nu-plugin-desktop-notifications branch from d69d82c to 283207d Compare June 14, 2025 00:00
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jun 14, 2025
@aldenparker aldenparker force-pushed the add-nu-plugin-desktop-notifications branch from 283207d to 16675e4 Compare June 14, 2025 00:21
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jun 14, 2025
@aldenparker aldenparker force-pushed the add-nu-plugin-desktop-notifications branch 2 times, most recently from 59dd9a9 to f2526b6 Compare June 14, 2025 02:57
@aldenparker
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 416331

Logs: https://github.com/aldenparker/nixpkgs-review-gha/actions/runs/15647740885


x86_64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop-notifications

aarch64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop-notifications

x86_64-darwin (sandbox = false)

✅ 1 package built:
  • nushellPlugins.desktop-notifications

aarch64-darwin (sandbox = false)

✅ 1 package built:
  • nushellPlugins.desktop-notifications

@aldenparker
Copy link
Contributor Author

Ok, so the problem was building it sandboxed for darwin. While it works, I do not know how to specify that in the package. Is there anything I have to do to specify that this can not be built sandboxed?

@aldenparker aldenparker force-pushed the add-nu-plugin-desktop-notifications branch from f2526b6 to 234f18f Compare June 14, 2025 04:06
@aldenparker
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 416331

Logs: https://github.com/aldenparker/nixpkgs-review-gha/actions/runs/15648254960


x86_64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop-notifications

aarch64-linux (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop-notifications

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop-notifications

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • nushellPlugins.desktop-notifications

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 16, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 30, 2025
@aldenparker
Copy link
Contributor Author

Closing due to lack of interest making it stale and the fact that I have now switched to fish shell so I wont be the best for maintaining this.

@aldenparker aldenparker closed this Jul 8, 2025
@aldenparker aldenparker deleted the add-nu-plugin-desktop-notifications branch July 8, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants