packet: 0.4.0 → 0.5.1 by honnip · Pull Request #416076 · NixOS/nixpkgs

honnip · 2025-06-12T08:31:35Z

https://github.com/nozwock/packet/releases/tag/0.5.0
https://github.com/nozwock/packet/releases/tag/0.5.0-1
https://github.com/nozwock/packet/releases/tag/0.5.1

NOTE: This update includes the Nautilus extension. Some additional configuration is required to make it work. See honnip/dotfiles@4a4c01c or nautilus-open-any-terminal module

Things done

Add a 👍 reaction to pull requests you find important.

honnip · 2025-06-12T08:38:47Z

screenshot

log:

nautilus[7181]: Packet: No ko_KR localization found for domain: 'packet'

non localized string is displayed in the Nautilus menu, and I have no idea how to fix it

make-42 · 2025-06-12T08:38:47Z

I'll have a look when I get back home later for both the update and why Korean i18n isn't working. Since the extra options aren't home manager options, I see no reason why we can't just make a module for packet to have a programs.packet attribute set that adds these options

honnip · 2025-06-12T08:58:16Z

I see no reason why we can't just make a programs entry that when enabled adds these options

Yes, you're right. I would like to see in other PR

make-42 · 2025-06-12T08:59:37Z

Sure!

make-42 · 2025-06-12T18:01:17Z

It compiles and runs fine on my machine! I use en-US as a locale so I can't reproduce your issue unless I use a VM. However from what I can see, it's supposed to be included in the data/resources/plugins/packet_nautilus.py file at line 113 on build time. It seems to be installed correctly. The only way I think it could be going wrong is if the locale dir isn't being found properly.

make-42 · 2025-06-12T18:16:05Z

Other than that, lgtm

nozwock · 2025-06-13T04:18:23Z

Currently, the extension only looks in two locale directories, the one given by Flatpak, and another being what python considers to be the default locale directory¹

Where are the packet.po files stored in the installed nix package?

https://docs.python.org/3/library/gettext.html#id3 ↩

nozwock · 2025-06-13T05:23:10Z

For now you might want to patch the None with a hard coded locale directory that's available in the installed nix package?

-    locale_dirs: List[Path | None] = [None]  # None for system default locale dir
+    locale_dirs: List[Path] = [Path("/path/to/localedir/containing/packet.po's")]

make-42 · 2025-06-13T08:00:14Z

That's exactly what my code suggestion does:

    substituteInPlace $out/share/packet/plugins/packet_nautilus.py \
      --replace-fail 'locale_dirs: List[Path | None] = [None]' \
                'locale_dirs: List[Path | None] = [Path("'"$out"'/share/locale"), None]'

Adds the local dir path on build

honnip · 2025-06-13T08:38:51Z

Thank you all. It works well

honnip · 2025-06-13T09:01:46Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 416076

Logs: https://github.com/honnip/nixpkgs-review-gha/actions/runs/15630594040

`x86_64-linux` (sandbox = true)

✅ 1 package built:

packet

`aarch64-linux` (sandbox = true)

✅ 1 package built:

packet

nozwock · 2025-06-13T09:16:33Z

That's exactly what my code suggestion does:

    substituteInPlace $out/share/packet/plugins/packet_nautilus.py \
      --replace-fail 'locale_dirs: List[Path | None] = [None]' \
                'locale_dirs: List[Path | None] = [Path("'"$out"'/share/locale"), None]'

Adds the local dir path on build

Interesting, I think I can just fix it on my end then, by having another directory to look for which is

<meson dest dir>/share/locale

pkgs/by-name/pa/packet/package.nix

nozwock · 2025-06-13T14:09:09Z

Interesting, I think I can just fix it on my end then, by having another directory to look for which is
<meson dest dir>/share/locale

Actually no, I forgot that I had already thought of this and got rid of the idea, since for a Flatpak build, the meson DEST_DIR would be /app and so the locale dir will end up being /app/share/locale which is not a directory accessible from the extension since it's only valid within the sandbox.

Not sure if the resulting path would be useful for a nixpkg though, you may try locally building with this patch and see if it works or not:

diff --git a/data/resources/plugins/meson.build b/data/resources/plugins/meson.build
index ac60edd..9e055b8 100644
--- a/data/resources/plugins/meson.build
+++ b/data/resources/plugins/meson.build
@@ -1,6 +1,7 @@
 plugins_conf = configuration_data()
 plugins_conf.set('APP_ID', application_id)
 plugins_conf.set('LOCALE_DOMAIN', gettext_package)
+plugins_conf.set('LOCALE_DIR', localedir)
 
 configure_file(
   input: 'packet_nautilus.py.in',
diff --git a/data/resources/plugins/packet_nautilus.py.in b/data/resources/plugins/packet_nautilus.py.in
index 9c5e71e..7288ee9 100755
--- a/data/resources/plugins/packet_nautilus.py.in
+++ b/data/resources/plugins/packet_nautilus.py.in
@@ -23,7 +23,8 @@ def log(*vals: Any):
 # TODO: Maybe have a separate gettext package for plugin scripts that gets
 # copied over alongside the script. Seems more robust?
 def init_i18n() -> gettext.NullTranslations | gettext.GNUTranslations:
-    locale_dirs: List[Path | None] = [None]  # None for system default locale dir
+    # `None` is for system default locale dir
+    locale_dirs: List[Path | None] = [None, Path("@LOCALE_DIR@")]
     (lang, enc) = locale.getlocale()
 
     flatpak_info = None

make-42 · 2025-06-13T21:43:27Z

Interesting, I think I can just fix it on my end then, by having another directory to look for which is
<meson dest dir>/share/locale

Actually no, I forgot that I had already thought of this and got rid of the idea, since for a Flatpak build, the meson DEST_DIR would be /app and so the locale dir will end up being /app/share/locale which is not a directory accessible from the extension since it's only valid within the sandbox.

Not sure if the resulting path would be useful for a nixpkg though, you may try locally building with this patch and see if it works or not:

diff --git a/data/resources/plugins/meson.build b/data/resources/plugins/meson.build
index ac60edd..9e055b8 100644
--- a/data/resources/plugins/meson.build
+++ b/data/resources/plugins/meson.build
@@ -1,6 +1,7 @@
 plugins_conf = configuration_data()
 plugins_conf.set('APP_ID', application_id)
 plugins_conf.set('LOCALE_DOMAIN', gettext_package)
+plugins_conf.set('LOCALE_DIR', localedir)
 
 configure_file(
   input: 'packet_nautilus.py.in',
diff --git a/data/resources/plugins/packet_nautilus.py.in b/data/resources/plugins/packet_nautilus.py.in
index 9c5e71e..7288ee9 100755
--- a/data/resources/plugins/packet_nautilus.py.in
+++ b/data/resources/plugins/packet_nautilus.py.in
@@ -23,7 +23,8 @@ def log(*vals: Any):
 # TODO: Maybe have a separate gettext package for plugin scripts that gets
 # copied over alongside the script. Seems more robust?
 def init_i18n() -> gettext.NullTranslations | gettext.GNUTranslations:
-    locale_dirs: List[Path | None] = [None]  # None for system default locale dir
+    # `None` is for system default locale dir
+    locale_dirs: List[Path | None] = [None, Path("@LOCALE_DIR@")]
     (lang, enc) = locale.getlocale()
 
     flatpak_info = None

That patch yields the perfect result:

If applied upstream it would make it so we don't have to do some ugly substitution to get the locale path. That's awesome

Aleksanaa · 2025-06-14T02:37:57Z

Sorry to bother you @wolfgangwalther, but the approval label seems to be doing wrong here. It added 12.approvals: 2 because make-42 approved two times (or some other reasons, like force push?).

wolfgangwalther · 2025-06-14T09:05:54Z

It added 12.approvals: 2 because make-42 approved two times

Yes, that seems to be the case 🙈

Thanks for the report!

Fix in #416668

wolfgangwalther · 2025-06-14T09:06:38Z

Sorry to bother you

And please keep reporting anything that seems wrong, I appreciate those reports!

Have another locale directory to look for which is based on meson's `DESTDIR`. `DESTDIR/share/locale` is where the locale seems to be stored for the built nixpkg. References: - NixOS/nixpkgs#416076 (comment)

nozwock · 2025-06-14T10:57:54Z

If applied upstream it would make it so we don't have to do some ugly substitution to get the locale path. That's awesome

I'll have it in the next release.

make-42 · 2025-06-14T10:59:00Z

Awesome, I'll also make a nix module for this package to have enable the necessary options for nautilus integration

github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 12, 2025

nix-owners bot requested a review from make-42 June 12, 2025 08:37

make-42 approved these changes Jun 12, 2025

View reviewed changes

wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 13, 2025

honnip force-pushed the update/packet branch from 3e23945 to d2ad5be Compare June 13, 2025 08:37

make-42 approved these changes Jun 13, 2025

View reviewed changes

pkgs/by-name/pa/packet/package.nix Outdated Show resolved Hide resolved

packet: 0.4.0 → 0.5.1

aa439f5

honnip force-pushed the update/packet branch from d2ad5be to aa439f5 Compare June 14, 2025 01:54

Aleksanaa approved these changes Jun 14, 2025

View reviewed changes

Aleksanaa merged commit 57b2cca into NixOS:master Jun 14, 2025
13 of 16 checks passed

wolfgangwalther mentioned this pull request Jun 14, 2025

workflows/labels: count approving reviewers, not reviews #416668

Merged

2 tasks

make-42 mentioned this pull request Jun 14, 2025

packet: add programs entry for enabling nautilus integration #416710

Open

13 tasks

Uh oh!

Conversation

honnip commented Jun 12, 2025

Things done

Uh oh!

honnip commented Jun 12, 2025

Uh oh!

make-42 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

honnip commented Jun 12, 2025

Uh oh!

make-42 commented Jun 12, 2025

Uh oh!

make-42 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

make-42 commented Jun 12, 2025

Uh oh!

nozwock commented Jun 13, 2025

Footnotes

Uh oh!

nozwock commented Jun 13, 2025

Uh oh!

make-42 commented Jun 13, 2025

Uh oh!

honnip commented Jun 13, 2025

Uh oh!

honnip commented Jun 13, 2025

nixpkgs-review result

x86_64-linux (sandbox = true)

aarch64-linux (sandbox = true)

Uh oh!

nozwock commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nozwock commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

make-42 commented Jun 13, 2025

Uh oh!

Uh oh!

Aleksanaa commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfgangwalther commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfgangwalther commented Jun 14, 2025

Uh oh!

nozwock commented Jun 14, 2025

Uh oh!

make-42 commented Jun 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

make-42 commented Jun 12, 2025 •

edited

Loading

make-42 commented Jun 12, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux` (sandbox = true)

`aarch64-linux` (sandbox = true)

nozwock commented Jun 13, 2025 •

edited

Loading

nozwock commented Jun 13, 2025 •

edited

Loading

Aleksanaa commented Jun 14, 2025 •

edited

Loading

wolfgangwalther commented Jun 14, 2025 •

edited

Loading