Skip to content

Conversation

@Aleksanaa
Copy link
Member

Description of changes

Closes #325193

Trying to fix tests

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa Aleksanaa marked this pull request as draft July 7, 2024 08:56
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 7, 2024
@Aleksanaa Aleksanaa force-pushed the shpool branch 2 times, most recently from e582ab9 to c1eb3e8 Compare July 7, 2024 18:09
@Aleksanaa
Copy link
Member Author

Linux-pam is available on macOS, but we haven't enabled it. Will investigate that latter

@sikmir
Copy link
Member

sikmir commented Jul 9, 2024

Linux-pam is available on macOS, but we haven't enabled it. Will investigate that latter

I guess macOS is not supported now, see shell-pool/shpool#48

@Aleksanaa Aleksanaa marked this pull request as ready for review July 9, 2024 15:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 9, 2024
@Aleksanaa Aleksanaa requested review from drupol and sikmir July 10, 2024 05:05
@drupol drupol merged commit 2823b04 into NixOS:master Jul 11, 2024
@AkechiShiro
Copy link
Contributor

Hi @Aleksanaa,

I couldn't manage to use the package, running the daemon failed however I'm on a non NixOS distro so maybe that's an issue with non NixOS distro and it works well under NixOS.

@AkechiShiro
Copy link
Contributor

I cannot find the systemd service that is installed when running systemd nor systemd --user, however under NixOS, I can find the service with systemd --user, not sure how it would be possible to fix this issue for non NixOS distros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: shpool

4 participants