backport src definition from 2.16#10390
Merged
thufschmitt merged 1 commit intoNixOS:2.15-maintenancefrom Apr 3, 2024
Merged
Conversation
fricklerhandwerk
added
the
build-problem
This fixes a weirdness when consuming `default.nix` from the 2.15 release branch archive,
where the Nix derivation's `src` store path gets wrapped for some reason:
"src": "/nix/store/mfa0j89j4f42nrxwxfwqrz0b6m32ih99-fcyq2x0wld440n9jc756vnh93kvjz9ac-source",
This is the only difference to instantiating the Nix derivation from the
repository itself, and prevents a build cache hit.
It doesn't happen on 2.14 (adds `flake-compat`) and 2.16 (uses `cleanSource`).
I suppose this is somehow caused by `flake-compat` doing something funky,
fricklerhandwerk
force-pushed
the
src-test
branch
from
9bfad1b to
86a6628
Compare
thufschmitt
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I just want to finish hosting versioned manuals and updating them automatically, without having to re-build multiple versions of Nix: NixOS/nix.dev#863
Context
This fixes a weirdness when consuming
default.nixfrom the 2.15 release branch archive, where the Nix derivation'ssrcstore path gets wrapped for some reason:This is the only difference to instantiating the Nix derivation from the repository itself, and prevents a build cache hit.
It doesn't happen on 2.14 (adds
flake-compat) and 2.16 (usescleanSource). I suppose this is somehow caused byflake-compatdoing something funky,Priorities
Add 👍 to pull requests you find important.