macos: strip trailing text from profiles command output#152
Merged
Conversation
`/usr/bin/profiles -P -o stdout-xml` emits plain text like "There are no configuration profiles installed" alongside the plist XML when no profiles exist. The position varies across macOS versions — some emit it after </plist>, others before <?xml. The plist parser rejects this as unexpected characters, causing check_suis() to skip the SystemUIServer policy check entirely with a warning. Extract just the <?xml...</plist> range before parsing so the MDM policy check works reliably regardless of surrounding text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/usr/bin/profiles -P -o stdout-xmlappends plain text like "There are no configuration profiles installed" after the closing tag when no profiles exist. The plist parser rejects this as unexpected characters, causing check_suis() to skip the SystemUIServer policy check entirely with a warning.Strip everything after before parsing so the MDM policy check works reliably on machines with no configuration profiles.
Description
Checklist