Repository navigation
Conversation
domenkozar
approved these changes
Mar 11, 2023
zimbatm
force-pushed
the
master
branch
2 times, most recently
from
April 11, 2023 17:20
e1bee88 to
2733ca6
Compare
Member
|
Text looks pretty good to me, only thing I'd add is a short reference to the general Code of Conduct we do have now. |
zimbatm
force-pushed
the
code-of-conduct-policy
branch
from
April 1, 2024 11:33
1637aaa to
b097e71
Compare
Member
Author
|
@NixOS/foundation please take a look so we can move forward. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
thufschmitt
approved these changes
Apr 11, 2024
thufschmitt
left a comment
thufschmitt
left a comment
Member
There was a problem hiding this comment.
Mh apologies, I thought I had approved this long ago.
But here it is then
Janik-Haag
suggested changes
Apr 11, 2024
Janik-Haag
left a comment
Janik-Haag
left a comment
Member
There was a problem hiding this comment.
This looks quite good to me except for one major thing: I would replace shall with must in most points. The US Government has quiet a nice page explaining the difference: https://www.plainlanguage.gov/guidelines/conversational/shall-and-must/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to help set the tone of our work internally and externally. And also hold ourselves to high standards.