Discord client detection with multi-variant support #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NextFire
requested changes
Apr 27, 2025
Co-authored-by: Nam Vu <[email protected]>
Co-authored-by: Nam Vu <[email protected]>
Co-authored-by: Nam Vu <[email protected]>
Co-authored-by: Nam Vu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the robustness of the Discord Rich Presence functionality by adding detection for various Discord client variants before attempting to establish a connection.
Changes
DiscordClientNametype to support all known Discord variants (Standard, Canary, PTB, Development)isAnyDiscordRunning()function that checks if any Discord variant is runningsetActivityLoop()method to verify Discord is running before connection attemptsBenefits
Testing
Tested with Discord Canary and Discord and verified that the Rich Presence status is correctly displayed only when a Discord client is running.
Notes
This change is backward compatible and doesn't affect any existing functionality. It simply adds a verification step before attempting to connect to the Discord RPC.