feat(currency-hub): add pagination, filtering, and search support with Swagger docs#105
Closed
mdauwal wants to merge 1 commit intoNexacore-Org:mainfrom
Closed
feat(currency-hub): add pagination, filtering, and search support with Swagger docs#105mdauwal wants to merge 1 commit intoNexacore-Org:mainfrom
mdauwal wants to merge 1 commit intoNexacore-Org:mainfrom
Conversation
portableDD
requested changes
Jun 2, 2025
| { ...baseFilters, baseCurrencyCode: Like(`%${search}%`) }, | ||
| { ...baseFilters, targetCurrencyCode: Like(`%${search}%`) }, | ||
| { ...baseFilters, provider: Like(`%${search}%`) }, | ||
| ); |
Contributor
There was a problem hiding this comment.
Where is this function, what happened to the?, please return them?
Author
|
This update merges enhanced filtering, pagination, and search capabilities into the existing CurrencyHub service logic while retaining all operational methods such as:
✅ Preserves all existing business logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Currency Hub: Paginated, Searchable Currency Data API
Summary
This PR enhances the
currency-hubmodule with:page,limit)QueryCurrencyHubDto@ApiQuery,@ApiOperationWhat's Included
QueryCurrencyHubDto— updated withpage,limit, andsearchcurrency-hub.service.ts— updatedfindAllmethod with full logiccurrency-hub.controller.ts— updated with Swagger decorators and updated endpointHow to Test
GET /currency-hub?page=1&limit=10?search=USD?baseCurrencyCode=USD&targetCurrencyCode=NGNCloses
Closes #56