Skip to content

fix: handle multiple root-level XML elements from non-conformant LLMs #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle multiple root-level XML elements from non-conformant LLMs #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/memu/app/memorize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,10 +1315,18 @@ def _parse_memory_type_response_xml(self, raw: str) -> list[dict[str, Any]]:
xml_content = raw[start_idx : end_idx + len(end_tag)]
xml_content = xml_content.replace("&", "&")

root = ET.fromstring(xml_content)
try:
root = ET.fromstring(xml_content)
except ET.ParseError:
# Some LLMs emit one <item> per memory rather than a single root
# element wrapping all memories, resulting in "junk after document
# element" when the slice contains multiple top-level tags. Wrap
# the content in a synthetic root element and retry.
root = ET.fromstring(f"<_root_>{xml_content}</_root_>")

result: list[dict[str, Any]] = []

for memory_elem in root.findall("memory"):
for memory_elem in root.iter("memory"):
parsed = self._parse_memory_element(memory_elem)
if parsed:
result.append(parsed)
Expand Down