docs(grok): fix MemoryService initialization example#405
Open
octo-patch wants to merge 1 commit intoNevaMind-AI:mainfrom
Open
docs(grok): fix MemoryService initialization example#405octo-patch wants to merge 1 commit intoNevaMind-AI:mainfrom
octo-patch wants to merge 1 commit intoNevaMind-AI:mainfrom
Conversation
The usage example in docs/providers/grok.md passed the LLMConfig object
via a non-existent `llm_config` keyword argument, which would raise:
TypeError: MemoryService.__init__() got an unexpected keyword argument 'llm_config'
The correct parameter is `llm_profiles` which accepts a dict mapping
profile names to LLMConfig instances. Also add os.environ.get()
for the API key so the example is runnable as written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The code example in
docs/providers/grok.mdpassesLLMConfigvia a non-existentllm_configkeyword argument:Running this code raises:
MemoryService.__init__does not acceptllm_config; the correct parameter isllm_profiles.Solution
llm_profiles={"default": llm_config}instead ofllm_config=llm_configos.environ.get("GROK_API_KEY", "")for the API key so the example is copy-pasteable and actually worksTesting
Verified by reading
MemoryService.__init__signature insrc/memu/app/service.py.