Skip to content

[WIP] Support NWB Schema 2.9.0 #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 27, 2025
Merged

[WIP] Support NWB Schema 2.9.0 #2092

merged 15 commits into from
Jun 27, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 5, 2025

Add support for upcoming NWB schema 2.9.0. This is a staging branch and will be merged into dev when all the 2.9.0 changes have been merged into here.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 97.65625% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.95%. Comparing base (cba0ae8) to head (7d7667a).
Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
src/pynwb/ecephys.py 91.30% 0 Missing and 2 partials ⚠️
src/pynwb/file.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2092      +/-   ##
==========================================
+ Coverage   94.83%   94.95%   +0.11%     
==========================================
  Files          28       28              
  Lines        2751     2832      +81     
  Branches      708      725      +17     
==========================================
+ Hits         2609     2689      +80     
- Misses         82       87       +5     
+ Partials       60       56       -4     
Flag Coverage Δ
integration 74.54% <81.25%> (+0.38%) ⬆️
unit 84.78% <86.71%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

stephprince and others added 6 commits June 9, 2025 13:49
* validate source_idx inputs for EventDetection

* add tests for EventDetection schema updates

* add 2D source index example for EventDetection

* fix formatting and comments

* update comments

* update CHANGELOG

* point to event detection schema branch

* Update schema submodule

---------

Co-authored-by: rly <[email protected]>
* add deprecation warning to eventdetection

* add tests for time deprecation

* update CHANGELOG
@rly rly marked this pull request as ready for review June 27, 2025 01:01
@rly rly enabled auto-merge (squash) June 27, 2025 01:01
@rly rly requested a review from stephprince June 27, 2025 01:01
@rly rly disabled auto-merge June 27, 2025 01:01
@rly rly enabled auto-merge June 27, 2025 01:01
@rly rly merged commit 618df86 into dev Jun 27, 2025
26 checks passed
@rly rly deleted the nwb-schema-2.9.0 branch June 27, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants