Skip to content

Adding support for Nicolet .e files #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 74 commits into
base: master
Choose a base branch
from

Conversation

MureziCapaul
Copy link

The reader for .e files as mentioned in #1510

MureziCapaul and others added 30 commits August 2, 2024 15:26
This reverts commit d8584b0001985f08ff1dc3db21b5c9fd372ea181, reversing
changes made to ac6aeda64635a2aae50a20b990cbab667d74734f.
@zm711
Copy link
Contributor

zm711 commented Jul 15, 2025

Great. We will review this soon. I'll work on getting the test file uploaded this week :)

@h-mayorquin
Copy link
Contributor

https://github.com/ieeg-portal/Nicolet-Reader

The matlab reader?

Do you have a pdf or link to the spec of the format?

@MureziCapaul
Copy link
Author

Hi @h-mayorquin ,

Yes, I basically translated to Matlab Code to python and added some optmimisations. I do not have any file specs.
I can try to inquire about the format spec, but since the format is likely closed (the Nicolet System is stil being sold by Natus) this might not be possible. I will keep you updated.

@h-mayorquin
Copy link
Contributor

Thanks. Yes, if the spec is not available we work with the matlab then. I am of the opinion that partial reading capabilities (that might be wrong) is better than waiting for the perfect reader. I have not read your PR but we just need to add disclaimers in that direction. Thanks for the update.

@MureziCapaul
Copy link
Author

@h-mayorquin Allright, that sound good. I will still get in contact with the company sales rep, he's apparently very helpful. The kind of validation I have is comparing the reader output with the Viewer-Software provided by the company. Signals, events, channels all match up for the handful of examples I looked at.

@samuelgarcia
Copy link
Contributor

Hi.
This looks like a very big effort for porting this reader.
Thank you very much.
I also will try to read this "quite" soon.

@h-mayorquin
Copy link
Contributor

If they can share a spec of the datalayout in bytes that would go great lengths to ease our job here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants