-
Notifications
You must be signed in to change notification settings - Fork 260
Adding support for Nicolet .e files #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…pull information from signal and timestream properties as needed
Great. We will review this soon. I'll work on getting the test file uploaded this week :) |
https://github.com/ieeg-portal/Nicolet-Reader The matlab reader? Do you have a pdf or link to the spec of the format? |
Hi @h-mayorquin , Yes, I basically translated to Matlab Code to python and added some optmimisations. I do not have any file specs. |
Thanks. Yes, if the spec is not available we work with the matlab then. I am of the opinion that partial reading capabilities (that might be wrong) is better than waiting for the perfect reader. I have not read your PR but we just need to add disclaimers in that direction. Thanks for the update. |
@h-mayorquin Allright, that sound good. I will still get in contact with the company sales rep, he's apparently very helpful. The kind of validation I have is comparing the reader output with the Viewer-Software provided by the company. Signals, events, channels all match up for the handful of examples I looked at. |
Hi. |
If they can share a spec of the datalayout in bytes that would go great lengths to ease our job here. |
The reader for .e files as mentioned in #1510