Skip to content

IPSec: multiple improvements #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gsanchietti merged 7 commits into from
Jan 26, 2026
Merged

IPSec: multiple improvements #1485

gsanchietti merged 7 commits into from
Jan 26, 2026

Conversation

@gsanchietti
Copy link
Member

@gsanchietti gsanchietti commented Jan 21, 2026 •
edited
Loading

@gsanchietti gsanchietti self-assigned this Jan 21, 2026
@gsanchietti gsanchietti requested a review from Copilot January 21, 2026 08:07

This comment was marked as outdated.

Sign in to view

@gsanchietti gsanchietti force-pushed the improve_ipsec branch 4 times, most recently from 49f087c to c6809bf Compare January 22, 2026 08:44
@gsanchietti gsanchietti mentioned this pull request Jan 22, 2026
Merged
@gsanchietti gsanchietti requested a review from Tbaile January 22, 2026 09:16
@gsanchietti gsanchietti marked this pull request as ready for review January 22, 2026 09:16
Tbaile
Tbaile reviewed Jan 22, 2026
View reviewed changes
@gsanchietti
fix: ipsec, avoid delete during edit
7686303 
When a tunnel is completely deleted during edit, swanctl can't handle
the changes without a full restart.
To avoid this issue, just edit changed fields.
@gsanchietti
feat: ipsectunnel, change closeaction
a81f5e9 
- New default value for closaction is 'trap' that tries to recreate the
  CHILD_SA
- Make the closeaction value editable
@gsanchietti
fix: ipsectunnel, minimize tunnel deletion
8b1f765
@gsanchietti
feat: ipsec, return status of each children
963ad34
@gsanchietti
feat(api): ipsec, add restart
24b671e
@gsanchietti
fix(api): ipsec, change default for closeaction
eb46bd8 
The `none` action is the recommended one by OpenWrt
When using different values, the swanctl init.d script logs the
following:

  WARNING: Closeaction start can cause instability
  WARNING: Closeaction trap can cause instability
@gsanchietti
fix(api): ipsec, improve option diff
47ec22e
@gsanchietti gsanchietti requested a review from Tbaile January 22, 2026 15:45
@gsanchietti gsanchietti merged commit d63441d into main Jan 26, 2026
2 checks passed
@gsanchietti gsanchietti deleted the improve_ipsec branch January 26, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Tbaile Tbaile Tbaile approved these changes

Assignees

@gsanchietti gsanchietti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsanchietti @Tbaile