Skip to content

feat(dpi): added additional logging when dpi blocks #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tbaile merged 2 commits into from
Jan 21, 2026
+17 −5
Merged

feat(dpi): added additional logging when dpi blocks #1482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
518562a
feat(dpi): added additional logging when dpi blocks
Tbaile Jan 20, 2026
1b112b2
Apply suggestions from code review
Tbaile Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ns-dpi/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=ns-dpi
PKG_VERSION:=0.2.0
PKG_RELEASE:=2
PKG_VERSION:=0.3.0
PKG_RELEASE:=1

PKG_BUILD_DIR:=$(BUILD_DIR)/ns-dpi-$(PKG_VERSION)

Expand Down
4 changes: 3 additions & 1 deletion packages/ns-dpi/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ To enable traffic processing:
Global options:

- `enabled`: can be `0` or `1`, if set to `1` enable the service
- `log_blocked`: can be `0` or `1`, if set to `1` blocked connections will be logged
- `log_blocked`: can be `0` or `1`, if set to `1` blocked connections will be logged inside `/var/log/messages`
- `firewall_exemption`: can be `0` or `1`, if set to `1` all firewall IP addresses will be
added to global exemption list and will not match DPI rules
- `popular_filters`: list of filters that will be returned to from `api-cli ns.dpi list-popular` call.
Expand All @@ -41,6 +41,8 @@ Rule options:
- `device`: optional device name, if set the rule will be applied only to the given device, example `br-lan`
- `application`: list of applications to match, the list can contain application names like `netify.amazon-prime`
- `enabled`: can be `0` or `1`, if set to `1` the rule will be enabled
- `log`: can be set to `1` to log matching connections, gives an improved visibility on matched connections;
logs are stored in `/var/run/netifyd/dpi-actions-*.json`

Global exemptions options:

Expand Down
14 changes: 12 additions & 2 deletions packages/ns-dpi/files/dpi-config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,14 @@ config = {
"other_port",
"other_addr"
]
}
},
"log": {
"target_type": "log",
"target_enabled": True,
"interval": 60,
"path": "/var/run/netifyd/",
"prefix": "dpi-actions",
},
},
"actions": {},
"exemptions": []
Expand Down Expand Up @@ -127,11 +134,14 @@ for section in u.get_all('dpi'):
criteria = f'vlan_id == {vlan_id} && {criteria}'
device = base_if

targets = [rule['action']]
if 'log' in rule and rule['log'] == '1':
targets.append('log')
config["actions"][f"rule{rcount}"] = {
"enabled": rule['enabled'] == '1',
"interface": device,
"criteria": criteria,
"targets": [rule['action']],
"targets": targets,
"exemptions": rule.get('exemption', [])
}
rcount = rcount + 1
Expand Down
Loading