Update Dockerfile.cuda #1380
Open
Update Dockerfile.cuda #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is a fix to Netflix#1379, wherein: 1. The CUDA library stubs are added to `ldconfig`'s cache. 2. The build type for `libvmaf` is set to `shared`. 3. The included models are also copied to `/usr/local/share/model` for re-usability with custom FFmpeg pipelines as needed. 4. `ldconfig` is called up immediately after `libvmaf` build so that `FFmpeg` can detect it.
Contributor
|
I think the FFmpeg build failure is due to the missing libcuda.so.1 library file. The vmaf is linked with libcuda.so.1 because of SONAME of libcuda.so is |
liuxunchenglxc
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a fix to #1379, wherein:
ldconfig's cache.libvmafis set toshared./usr/local/share/modelfor re-usability with custom FFmpeg pipelines as needed.ldconfigis called up immediately afterlibvmafbuild so thatFFmpegcan detect it.