Add option to ignore parent proc env vars in runner/deployer #2544
+12
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
Currently, runner/deployer always users the environment of the context in which it was launched as the base environment, and updates it with the environment provided by the user.
This causes weird issues like the following:
When using deployer/runner to deploy a flow from a step within another flow, it automatically sets
environment=conda
for the deployed flow even if we didn't set it explicitly.Bug:
Fix:
Allow users to specify the appropriate behavior for their context via an argument:
extend_existing_env
.