Set Geography.IsLargerThanAHemisphere value #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refers also to #12
Add initial unit tests. It seems that using GeocentricTransform is overkill, plain sphere math might do, @brieclam?
Collaborator
|
The SQL Server serialization format has a flag for this too--the H bit of the Serialization Properties byte in version 2 of the GEOGRAPHY structure. Can we add a test serializing one of these values to make sure we match the SQL Server behavior? |
Collaborator
|
Ah, I see, this is setting the flag so it gets serialized. 🤦 In that case, yeah, adding a serialization test would be nice. You can get the bytes SQL Server returns using a query like the following. SELECT CONVERT(nvarchar, geography::STGeomFromText('POINT (0 90)', 4326).STBuffer(500).Serialize(), 2); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.