Skip to content

miscfs/fullfs: add disk-full simulation layerfs based on miscfs/nullfs#79

Draft
dalpra-hcd wants to merge 2 commits intoNetBSD:trunkfrom
dalpra-hcd:implement-fullfs
Draft

miscfs/fullfs: add disk-full simulation layerfs based on miscfs/nullfs#79
dalpra-hcd wants to merge 2 commits intoNetBSD:trunkfrom
dalpra-hcd:implement-fullfs

Conversation

@dalpra-hcd
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Contributor

@zoulasc zoulasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minor nits.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would probably use strtoi()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the 1's should be EXIT_FAILURE.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have estrdup() in libutil... and other e-functions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strtoi again...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can put the index declaration in the loop.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRIu64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't want to allow it to be 0 again?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsigned?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsigned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants