fix(babel-preset-taro): 配置中使用了不正确的插件#16726
fix(babel-preset-taro): 配置中使用了不正确的插件#16726skyclouds2001 wants to merge 4 commits intoNervJS:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16726 +/- ##
=======================================
Coverage 57.70% 57.70%
=======================================
Files 469 469
Lines 26551 26551
Branches 5722 5704 -18
=======================================
Hits 15321 15321
- Misses 9765 9859 +94
+ Partials 1465 1371 -94
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Caution Review failedThe pull request is closed. Walkthrough此次变更在 Changes
Sequence Diagram(s)sequenceDiagram
participant BabelPreset as Babel 预设模块
participant ExportFunc as 模块导出函数
participant PluginArr as 插件数组
BabelPreset->>ExportFunc: 加载配置
ExportFunc->>PluginArr: 获取插件列表
PluginArr-->>ExportFunc: 返回插件列表(包含 @babel/plugin-transform-class-properties)
ExportFunc-->>BabelPreset: 返回完整配置
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
closing due to #17385 has been merged |
这个 PR 做了什么? (简要描述所做更改)
更新 babel 使用的插件名称
@babel/plugin-proposal-class-properties 插件已弃用,应采用 @babel/plugin-transform-class-properties
注意到 package.json 中已更新使用新插件,但 index.js 中尚未更新使用新插件
查看提交记录注意到对应插件已在 2ca1ce59c49d7900f6a098165299c2c52ea0548d 提交中更新为新插件,但在 c7688632f566016465e257756707acafbac604a6 中意外地恢复为弃用的原插件(但未恢复 package.json 中的)
在合并该 PR 后,就可以回退 5400d1f4bd538bdb5e022e0a3abccb92f1483826,从项目模板中移除该弃用的插件,参见 #16727
Note
考虑到该插件已被包含在
@babel/preset-env中,未来可以考虑移除该插件同时参见文档更新 NervJS/taro-docs#284
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
Summary by CodeRabbit