fix(task): resolve sf executable reliably on Windows and add Playwright task commands#59
Open
NerioVillalobos wants to merge 10 commits intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sfbinary is not resolved byspawnSync.ENOENT) into diagnostic output so users receive actionable messages instead of a generic fallback.Description
getSfCommandCandidates,executeSfCommand, and enhancedrunSfJsonCommandto trySF_BINPATH,sf, andsf.cmdand enableshellonwin32, capturing spawn errors intocombinedOutputfor diagnostics (insrc/utils/task/orchestrator.js).buildFrontdoorUrlFromOrgDisplayto attemptorg display --verbose --json,org open --url-only --json, andorg display --jsonand throw a consolidated, user-friendly error viaextractSfErrorMessagewhen none succeed.metadelta task recordandmetadelta task playcommands,TaskOrchestrator(error/solutions persistence), Playwright readiness/install helpers, test injection/patching (injectBaseUrlInTest, test normalization), and route helpers (addedtests/metadelta-task-orchestrator-routes.jsand JSON data fixture).lib/outputs, addedoclif.manifest.jsonentries for the new commands, updatedREADME.mdwith a linked-ESM build note, and added apreparescript inpackage.jsonto runnpm run build.Testing
npm run build, which completed successfully and regenerated compiledlib/artifacts and the updatedoclif.manifest.json(build passed).buildFrontdoorUrlFromOrgDisplayand SF execution helpers are present in bothsrc/andlib/outputs by inspecting the generated files (inspection passed).Codex Task